Add regular ecto migration with numeric ids v2 schemas #2768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aerosol
changed the title
aerosol
force-pushed
the
numeric-ids-migration-control-module
branch
from
83486ca
to
06f22bc
Compare
aerosol
force-pushed
the
numerc-ids-migration-for-test-purposes
branch
from
461f043
to
3aac5fe
Compare
8 tasks
vinibrsl
approved these changes
Mar 22, 2023
priv/ingest_repo/migrations/20230320094327_create_v2_schemas.exs
Outdated
Show resolved
Hide resolved
Co-authored-by: Vini Brasil <vini@hey.com>
* Implement v2 events/sessions schema modules * Clean up session schemas
aerosol
added a commit
that referenced
this pull request
Mar 23, 2023
* Implement Numeric IDs migration * Fix typo * Mute credo for now * Improve configurability and add stop_t * Adjust to Ch/Chto only * Fix opts key for dictionary password * Add regular ecto migration with numeric ids v2 schemas (#2768) * Add regular ecto migration * Fix typo * Update priv/ingest_repo/migrations/20230320094327_create_v2_schemas.exs Co-authored-by: Vini Brasil <vini@hey.com> * Implement v2 events/sessions schema modules (#2777) * Implement v2 events/sessions schema modules * Clean up session schemas --------- Co-authored-by: Vini Brasil <vini@hey.com> * Update moduledocs --------- Co-authored-by: Vini Brasil <vini@hey.com>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This work is on top of, and against #2762.
Normally, for live environments the migration will be done via
DataMigration.NumericIDsmodule (TBD). In which casePASS_V2_SCHEMA_MIGRATIONenvironment variable needs to be set, to only make the standard migrate
command write an entry into
schema_migrationstable.For tests, and entirely new self-hosted instances however,
we want to keep the ability of preparing the database without enforcing
any data migration.
Tests
Changelog
Documentation
Dark mode