IP Block List #3761
Merged
IP Block List #3761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ukutaht
approved these changes
Feb 12, 2024
aerosol
added
the
deploy-to-staging
This was referenced Feb 20, 2024
Merged
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR introduces a basic IP Block List feature. Users are able to add up to 30 IP (v4/v6) Addresses that will be rejected on ingest. A common use case is to block own IP, and this is hopefully made easy. IP ranges (netmask support) will be implemented in a follow-up if there's demand.
The rules are kept in a separate cache process for ingestion lookups and refreshed periodically.
BTW some room is already made for the upcoming Shields - the main live view will later on contain tabs with rule counters.
Reviewing commit-by-commit should work, and apologies for +1k, can split if anyone's struggling.
The docs will require an update + the ℹ️ heroicon link is currently missing from the panel. Migration will be extracted to a separate PR once review is conducted.
There's one minor annoyance withEcto.Network, ref adam12/ecto_network#28record-2024-02-07-15-08-19-demo.moen.rule.mp4
edit: Added simple "updated_by" tracking
record-2024-02-08-16-16-26-gulp.john.owls.mp4
Tests
Changelog
Documentation
Dark mode