Shield: Country Rules #3828
Shield: Country Rules #3828
Conversation
aerosol
added
the
deploy-to-staging
| <span | ||
| id={"country-#{rule.id}"} | ||
| class="mr-4 cursor-help border-b border-dotted border-gray-400" | ||
| title={"Added at #{rule.updated_at} by #{rule.added_by}"} |
There was a problem hiding this comment.
This seems to be an UTC timestamp, not the users local time, will this cause confusion?
There was a problem hiding this comment.
Nice, I'll use site's timezone.
There was a problem hiding this comment.
Oh wait, this only renders a date
|
|
||
| assert element_exists?( | ||
| resp, | ||
| ~s/button[phx-click="remove-country-rule"][phx-value-rule-id="#{r2.id}"]#remove-country-rule-#{r2.id}/ |
There was a problem hiding this comment.
This is clunky. Idea: Should we add a custom attribute to this element, e.g. data-test-remove-rule="123"? IMO this would make tests much easier to write and follow and would allow for separation of concerns.
There was a problem hiding this comment.
Only for the sake of test selectors? I think using phx- attributes is meaningful because it implies LV picks them up.
There was a problem hiding this comment.
How about I make this more readable?
And simplify+test Timezone module; an input timestamp converted to UTC can never be ambiguous.
Changes
This is very similar to #3761 - allows users to store up to 30 country codes that will be rejected on ingestion against the geolocation classification.
Migration will be extracted to a separate PR.
Notable differences/changes:
Global bugfix: ComboBox resumes suggestions popup after hitting Escape while typing
Extra:
Plausible.Timezonemodule was simplified + tests were addedTests
Changelog
Documentation
Dark mode