Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dockerfile and co updates #3811

Merged
merged 29 commits into from
Mar 8, 2024
Merged

Dockerfile and co updates #3811

merged 29 commits into from
Mar 8, 2024

Conversation

ruslandoga
Copy link
Contributor

In place of #2986

@ruslandoga
wip
60641ba
@ruslandoga
more env, setup user before packages to avoid them picking our uid
57698c1
@ruslandoga
make entrypoint.sh executable by all again
2289051
@ruslandoga
apparently it's a best practice to have executables be owned by root
b6a9e0a
@ruslandoga
make entrypoint executable in COPY
7abc335
@ruslandoga
stop writing to /app, write to /tmp if needed
608fd06
@ruslandoga
fewer changes
7b0635a
@ruslandoga
system user
e99b63c
@ruslandoga
keep same style for multiline commands
7c459cb
@ruslandoga
fewer changes
47a8cd0
@ruslandoga
add changelog entry
64c5e01
@ruslandoga
fix group assignment for plausible user
cbd0a7b
@ruslandoga
use gid=999
58a799b
@ruslandoga
no home
74919ec
@ruslandoga
no home
925ead8
@ruslandoga
add gecos
bbc8cea
@ruslandoga
add plausible user to nogroup instead of creating a custom one
fea37b1
@ruslandoga
eh
1305b80
@ruslandoga
fewer changes
4ddb4ae
@ruslandoga
fewer changes
55199db
@ruslandoga
fewer changes
f2f8b52
@ruslandoga
use PERSISTENT_CACHE_DIR instead of STORAGE_DIR
abcedbe
@ruslandoga
ignore more
6b34d05
@ruslandoga
cleanup
5afde46
@ruslandoga
remove hex timeout env var
12c74f0
@ruslandoga
use ERL_FLAGS=+JMsingle true in public builds
cfe8d35
@ruslandoga ruslandoga requested a review from cnkk February 22, 2024 14:35
@cnkk cnkk added the deploy-to-staging Special label that triggers a deploy to a staging environment label Feb 22, 2024
@ruslandoga ruslandoga mentioned this pull request Feb 26, 2024
Closed
5 tasks
macobo added a commit that referenced this pull request Mar 8, 2024
@macobo
Temporarily disable tzdata auto-updating
a51921d 
This can cause issues as 1 day after a deploy the tzdata list is updated
from 2021 to 2024. Selecting a timezone thats not supported in 2021 can
then break dashboards temporarily following a deploy.

This can be reverted after #3811
@macobo macobo mentioned this pull request Mar 8, 2024
Merged
macobo added a commit that referenced this pull request Mar 8, 2024
@macobo
Temporarily disable tzdata auto-updating (#3873)
11368e5 
This can cause issues as 1 day after a deploy the tzdata list is updated
from 2021 to 2024. Selecting a timezone thats not supported in 2021 can
then break dashboards temporarily following a deploy.

This can be reverted after #3811
@macobo
Copy link
Contributor

macobo commented Mar 8, 2024

Please revert #3873 once this is merged - this helps fix a bug with timezone handling that PR works around in an ugly way.

@ruslandoga
Copy link
Contributor Author

ruslandoga commented Mar 8, 2024 •
edited
Loading

We can also switch to tz which is supposed to be both faster and more correct. It should include a more recent database by default as well (right now it's 2023c). It builds the tz database during compilation so it should be reasonably up-to-date at start-up time.

@cnkk cnkk merged commit 83a46fb into master Mar 8, 2024
5 checks passed
@cnkk cnkk deleted the dockerfile-wip branch March 8, 2024 14:34
@ruslandoga ruslandoga mentioned this pull request Mar 15, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cnkk cnkk cnkk approved these changes

Assignees
No one assigned
Labels
deploy-to-staging Special label that triggers a deploy to a staging environment
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ruslandoga @macobo @cnkk