Don’t include code using vertex_tangent unless needed (#5176)

Co-authored-by: Martin Valigursky <mvaligursky@snapchat.com>
playcanvas · Mar 22, 2023 · eacc336 · eacc336
1 parent 6b7dd33
commit eacc336
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 6 deletions.
diff --git a/src/scene/shader-lib/chunks/lit/vert/tangentBinormal.js b/src/scene/shader-lib/chunks/lit/vert/tangentBinormal.js
@@ -6,8 +6,4 @@ vec3 getTangent() {
 vec3 getBinormal() {
     return cross(vNormalW, vTangentW) * vertex_tangent.w;
 }
-
-vec3 getObjectSpaceUp() {
-    return normalize(dNormalMatrix * vec3(0, 1, 0));
-}
 `;
diff --git a/src/scene/shader-lib/programs/lit-shader.js b/src/scene/shader-lib/programs/lit-shader.js
@@ -273,8 +273,7 @@ class LitShader {
                 codeBody += "   vTangentW   = getTangent();\n";
                 codeBody += "   vBinormalW  = getBinormal();\n";
             } else if (options.enableGGXSpecular || !device.extStandardDerivatives) {
-                code += chunks.tangentBinormalVS;
-                codeBody += "   vObjectSpaceUpW  = getObjectSpaceUp();\n";
+                codeBody += "   vObjectSpaceUpW = normalize(dNormalMatrix * vec3(0, 1, 0));\n";
             }
         }