Don’t include code using vertex_tangent unless needed #5176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chunk tangentBinormalVS contains handling of tangent and binormal, and should only be included if vertex buffer contains tangent, gated by options.hasTangents. But unrelated getObjectSpaceUp was included in this chunk and needed in cases hasTangent was false. This was adding
attribute vec4 vertex_tangent;to vertex shader even though vertex format did not have tangent, failing on WebGPU.The unrelated
getObjectSpaceUphas been removed from the chunk now.