Fix tags remove error #2432
Merged
Fix tags remove error #2432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willeastcott
approved these changes
Sep 15, 2020
mvaligursky
added a commit
that referenced
this pull request
Sep 21, 2020
commit ad6fd49 Author: Elliott Thompson <ellth92@gmail.com> Date: Fri Sep 18 15:14:20 2020 +0100 update the anim controller update function to fix certain transition states (#2434) commit 3b9983c Author: Martin Valigursky <59932779+mvaligursky@users.noreply.github.com> Date: Thu Sep 17 17:57:11 2020 +0100 Mini-stats update with functionality and flexibility (#2428) * Mini-stats - separated file into per-class files. * fixed typo in comment * implemented new features * lint fix * small improvements * small changes (white text, black clear color, smaller gaps between graphs) * text labels are slightly darker than numbers * tracking basic frame timing and drawCall count even in release build * spacing updates * black background when graph is disabled * size adjustement commit 5389039 Author: moka <core@moka.co> Date: Wed Sep 16 00:03:00 2020 +0200 [FIX] tags remove error (#2432) commit 4b711a7 Author: imgbot[bot] <31301654+imgbot[bot]@users.noreply.github.com> Date: Tue Sep 15 16:29:08 2020 +0100 [ImgBot] Optimize images (#2430) /examples/assets/textures/normal-map.png -- 736.03kb -> 595.91kb (19.04%) Signed-off-by: ImgBotApp <ImgBotHelp@gmail.com> Co-authored-by: ImgBotApp <ImgBotHelp@gmail.com> commit 0f14984 Author: Martin Valigursky <59932779+mvaligursky@users.noreply.github.com> Date: Tue Sep 15 15:18:30 2020 +0100 Refraction engine example and small related engine fix (#2429) * Refraction engine example and small related engine fix * small change in how grab texture is set up to only use public interface * offset centering * using mesh UVs to sample offset texture instead of screen position * renamed to grab-pass commit 5b82eb9 Author: moka <core@moka.co> Date: Thu Sep 10 18:58:56 2020 +0200 expose session and frame for WebXR (#2422) commit 8746592 Author: Ray Tran <raytranuk@users.noreply.github.com> Date: Wed Sep 9 09:54:37 2020 +0100 Warning added when element input is enabled, but no pc.ElementInput is created to fire input events (#2419) Warning added when element input is enabled, but no pc.ElementInput is created to fire input events This will greatly help debugging a problem I wasted hours on - where element input event were not firing without any indication of why. commit 6279a2b Author: Martin Valigursky <59932779+mvaligursky@users.noreply.github.com> Date: Tue Sep 8 19:26:46 2020 +0100 Frustum culling on camera created by code defaults to true (#2415) commit f2476b3 Author: Donovan Hutchence <slimbuck7@gmail.com> Date: Tue Sep 8 15:32:06 2020 +0100 [VERSION] v1.36.0-dev commit 100604b Author: Donovan Hutchence <slimbuck7@gmail.com> Date: Tue Sep 8 15:32:06 2020 +0100 [RELEASE] v1.35.0 commit e5d6bca Author: Martin Valigursky <59932779+mvaligursky@users.noreply.github.com> Date: Mon Sep 7 16:21:26 2020 +0100 [Fix] Supporting pass specific mesh-instance parameters as they are used by the Editor (#2411) commit e129194 Author: Donovan Hutchence <slimbuck7@gmail.com> Date: Mon Sep 7 12:17:08 2020 +0100 Simplify binder logic (#2401) * simplify binder * invoke setter when driving vector members commit 9cedb85 Author: Ray Tran <raytranuk@users.noreply.github.com> Date: Fri Sep 4 17:08:39 2020 +0100 Revert "Fix normals when mesh has both two-sided material and negative scale (#2375)" (#2406) This reverts commit 4d5f59d. # Conflicts: # src/graphics/program-lib/programs/standard.js commit 55e477a Author: Martin Valigursky <59932779+mvaligursky@users.noreply.github.com> Date: Fri Sep 4 15:06:39 2020 +0100 [Fix] Fixing return type of Entity.findComponents to be an array (#2405) commit 0e3022c Author: zachpeterpaul <49728898+zachpeterpaul@users.noreply.github.com> Date: Wed Sep 2 10:24:11 2020 -0700 Support for a more compressed scene file format (#2294) * initial decompress * do nothing without the compressed field * move decompress data * decompress in template * decompress in hierarchy * use underscores with private vars * rm else return * refactor parser for speed * rm expanding entities in templates * decompress entities only * move decompress to scene parser * initial decompress * handle triple vectors * reorder array and map check * change map check * rename fields * use field map array * edits for lint * comments in decompress * move decompress call to parser * add utils comments Co-authored-by: zachppaul <zachppaul@gmail.com>
yaustar
added a commit
that referenced
this pull request
Sep 29, 2020
* [VERSION] v1.36.0-dev * Frustum culling on camera created by code defaults to true (#2415) * Warning added when element input is enabled, but no pc.ElementInput is created to fire input events (#2419) Warning added when element input is enabled, but no pc.ElementInput is created to fire input events This will greatly help debugging a problem I wasted hours on - where element input event were not firing without any indication of why. * expose session and frame for WebXR (#2422) * Refraction engine example and small related engine fix (#2429) * Refraction engine example and small related engine fix * small change in how grab texture is set up to only use public interface * offset centering * using mesh UVs to sample offset texture instead of screen position * renamed to grab-pass * [ImgBot] Optimize images (#2430) /examples/assets/textures/normal-map.png -- 736.03kb -> 595.91kb (19.04%) Signed-off-by: ImgBotApp <ImgBotHelp@gmail.com> Co-authored-by: ImgBotApp <ImgBotHelp@gmail.com> * [FIX] tags remove error (#2432) * Mini-stats update with functionality and flexibility (#2428) * Mini-stats - separated file into per-class files. * fixed typo in comment * implemented new features * lint fix * small improvements * small changes (white text, black clear color, smaller gaps between graphs) * text labels are slightly darker than numbers * tracking basic frame timing and drawCall count even in release build * spacing updates * black background when graph is disabled * size adjustement * update the anim controller update function to fix certain transition states (#2434) * [FIX] Copy paste typo in Vec2 and Vec3 classes (#2436) * Update vec2.js Documentation copypasta fix * Update vec3.js * Fix for instanced rendering VB setup for the second eye in VR (#2446) * Removes global data when Component System is destroyed (#2448) Fixes #2442 Co-authored-by: Steven Yau <syau@snaphcat.com> * [RELEASE] v1.35.1 Co-authored-by: Donovan Hutchence <slimbuck7@gmail.com> Co-authored-by: Martin Valigursky <59932779+mvaligursky@users.noreply.github.com> Co-authored-by: Ray Tran <raytranuk@users.noreply.github.com> Co-authored-by: moka <core@moka.co> Co-authored-by: imgbot[bot] <31301654+imgbot[bot]@users.noreply.github.com> Co-authored-by: ImgBotApp <ImgBotHelp@gmail.com> Co-authored-by: Elliott Thompson <ellth92@gmail.com> Co-authored-by: Kotov Oleg <oleg.sveshnickov@yandex.ru> Co-authored-by: Steven Yau <syau@snaphcat.com>
mvaligursky
added a commit
that referenced
this pull request
Oct 7, 2020
commit d369b82 Author: Martin Valigursky <59932779+mvaligursky@users.noreply.github.com> Date: Wed Oct 7 10:58:40 2020 +0100 Optimized culling solution for skinned meshes (#2435) * ModelComponent can specify oversize bounding box and disable expensive skinned bounds update * es5 compatibility commit f1692a6 Author: Will Eastcott <will@playcanvas.com> Date: Mon Oct 5 20:44:34 2020 +0100 [FIX] Minor corrections to Typescript definitions (#2459) * [FIX] Minor corrections to Typescript definitions * Handle all function signatures for pc.Tags commit 524aeb0 Author: Elliott Thompson <ellth92@gmail.com> Date: Thu Oct 1 17:43:09 2020 +0100 update transition offset jsdoc and fix the state timeline duration property (#2457) commit bcf1b3f Author: Elliott Thompson <ellth92@gmail.com> Date: Thu Oct 1 16:47:06 2020 +0100 AnimComponent - Blend Trees (#2443) * anim component - blend trees commit b2243ff Author: moka <core@moka.co> Date: Wed Sep 30 16:12:52 2020 +0300 add particle define to particle shaders (#2454) commit 7630827 Author: Steven <yaustar@users.noreply.github.com> Date: Tue Sep 29 16:59:02 2020 +0100 Call upgradeDataSchema if there is no error (#2450) Co-authored-by: Steven Yau <syau@snaphcat.com> commit db49fe8 Author: moka <core@moka.co> Date: Tue Sep 29 18:58:52 2020 +0300 WebXR optionalFeatures options and change to `start` method (#2397) * WebXR optionalFeatures options and change to `start` method * corrections commit 7e0f0a5 Author: Donovan Hutchence <slimbuck7@gmail.com> Date: Tue Sep 29 12:43:32 2020 +0100 [VERSION] v1.36.0-dev commit 3317bcf Author: Donovan Hutchence <slimbuck7@gmail.com> Date: Tue Sep 29 12:43:32 2020 +0100 [RELEASE] v1.35.1 commit a617df9 Author: Steven <yaustar@users.noreply.github.com> Date: Fri Sep 25 14:29:33 2020 +0100 Removes global data when Component System is destroyed (#2448) Fixes #2442 Co-authored-by: Steven Yau <syau@snaphcat.com> commit 0a22646 Author: Martin Valigursky <59932779+mvaligursky@users.noreply.github.com> Date: Fri Sep 25 09:59:17 2020 +0100 Fix for instanced rendering VB setup for the second eye in VR (#2446) commit 06b6e2f Author: Kotov Oleg <oleg.sveshnickov@yandex.ru> Date: Tue Sep 22 03:06:43 2020 +0300 [FIX] Copy paste typo in Vec2 and Vec3 classes (#2436) * Update vec2.js Documentation copypasta fix * Update vec3.js commit ad6fd49 Author: Elliott Thompson <ellth92@gmail.com> Date: Fri Sep 18 15:14:20 2020 +0100 update the anim controller update function to fix certain transition states (#2434) commit 3b9983c Author: Martin Valigursky <59932779+mvaligursky@users.noreply.github.com> Date: Thu Sep 17 17:57:11 2020 +0100 Mini-stats update with functionality and flexibility (#2428) * Mini-stats - separated file into per-class files. * fixed typo in comment * implemented new features * lint fix * small improvements * small changes (white text, black clear color, smaller gaps between graphs) * text labels are slightly darker than numbers * tracking basic frame timing and drawCall count even in release build * spacing updates * black background when graph is disabled * size adjustement commit 5389039 Author: moka <core@moka.co> Date: Wed Sep 16 00:03:00 2020 +0200 [FIX] tags remove error (#2432) commit 4b711a7 Author: imgbot[bot] <31301654+imgbot[bot]@users.noreply.github.com> Date: Tue Sep 15 16:29:08 2020 +0100 [ImgBot] Optimize images (#2430) /examples/assets/textures/normal-map.png -- 736.03kb -> 595.91kb (19.04%) Signed-off-by: ImgBotApp <ImgBotHelp@gmail.com> Co-authored-by: ImgBotApp <ImgBotHelp@gmail.com> commit 0f14984 Author: Martin Valigursky <59932779+mvaligursky@users.noreply.github.com> Date: Tue Sep 15 15:18:30 2020 +0100 Refraction engine example and small related engine fix (#2429) * Refraction engine example and small related engine fix * small change in how grab texture is set up to only use public interface * offset centering * using mesh UVs to sample offset texture instead of screen position * renamed to grab-pass commit 5b82eb9 Author: moka <core@moka.co> Date: Thu Sep 10 18:58:56 2020 +0200 expose session and frame for WebXR (#2422) commit 8746592 Author: Ray Tran <raytranuk@users.noreply.github.com> Date: Wed Sep 9 09:54:37 2020 +0100 Warning added when element input is enabled, but no pc.ElementInput is created to fire input events (#2419) Warning added when element input is enabled, but no pc.ElementInput is created to fire input events This will greatly help debugging a problem I wasted hours on - where element input event were not firing without any indication of why. commit 6279a2b Author: Martin Valigursky <59932779+mvaligursky@users.noreply.github.com> Date: Tue Sep 8 19:26:46 2020 +0100 Frustum culling on camera created by code defaults to true (#2415) commit f2476b3 Author: Donovan Hutchence <slimbuck7@gmail.com> Date: Tue Sep 8 15:32:06 2020 +0100 [VERSION] v1.36.0-dev commit 100604b Author: Donovan Hutchence <slimbuck7@gmail.com> Date: Tue Sep 8 15:32:06 2020 +0100 [RELEASE] v1.35.0 commit e5d6bca Author: Martin Valigursky <59932779+mvaligursky@users.noreply.github.com> Date: Mon Sep 7 16:21:26 2020 +0100 [Fix] Supporting pass specific mesh-instance parameters as they are used by the Editor (#2411) commit e129194 Author: Donovan Hutchence <slimbuck7@gmail.com> Date: Mon Sep 7 12:17:08 2020 +0100 Simplify binder logic (#2401) * simplify binder * invoke setter when driving vector members commit 9cedb85 Author: Ray Tran <raytranuk@users.noreply.github.com> Date: Fri Sep 4 17:08:39 2020 +0100 Revert "Fix normals when mesh has both two-sided material and negative scale (#2375)" (#2406) This reverts commit 4d5f59d. # Conflicts: # src/graphics/program-lib/programs/standard.js commit 55e477a Author: Martin Valigursky <59932779+mvaligursky@users.noreply.github.com> Date: Fri Sep 4 15:06:39 2020 +0100 [Fix] Fixing return type of Entity.findComponents to be an array (#2405) commit 0e3022c Author: zachpeterpaul <49728898+zachpeterpaul@users.noreply.github.com> Date: Wed Sep 2 10:24:11 2020 -0700 Support for a more compressed scene file format (#2294) * initial decompress * do nothing without the compressed field * move decompress data * decompress in template * decompress in hierarchy * use underscores with private vars * rm else return * refactor parser for speed * rm expanding entities in templates * decompress entities only * move decompress to scene parser * initial decompress * handle triple vectors * reorder array and map check * change map check * rename fields * use field map array * edits for lint * comments in decompress * move decompress call to parser * add utils comments Co-authored-by: zachppaul <zachppaul@gmail.com>
mvaligursky
added a commit
that referenced
this pull request
Dec 7, 2020
* RenderComponent - new component to replace ModelComponent * small optimization * removed unused properties from cloning * using instanceof to test type * lint * moved getShapePrimitive to procedural instead of component system * small fixes * small fix * Squashed commit of the following: commit 199cc41 Author: Martin Valigursky <59932779+mvaligursky@users.noreply.github.com> Date: Wed Sep 2 11:52:29 2020 +0100 Changes to Camera.screenToWorld to improve precision with large frustum depth range (#2400) commit e2a1517 Author: Martin Valigursky <59932779+mvaligursky@users.noreply.github.com> Date: Tue Sep 1 10:44:37 2020 +0100 [Fix] Shader parameters set on Material or MeshInstance are used in all passes (#2391) * [Fix] Shader parameters set on Material or MeshInstance are used in all passes * additional cleanup and function reuse for unsetting meshinstance uniform overrides commit 3cc6588 Author: Martin Valigursky <59932779+mvaligursky@users.noreply.github.com> Date: Tue Sep 1 09:36:44 2020 +0100 Separated SkinInstance class into its own file skin-instance.js (#2394) commit 525fc08 Author: moka <core@moka.co> Date: Tue Sep 1 00:42:30 2020 +0200 WebXR Input Sources: retrieve most relevant transforms of the parent (#2395) * retrieve most relevant transforms of the parent * fix commit d96a75e Author: Aidin Abedi <aidinabedi@gmail.com> Date: Thu Aug 27 19:55:24 2020 +0200 Improve clear-coat material and add KHR_materials_clearcoat support in glTF parser (#2377) * add clear coat shader chunks * make clear coat shader variables global (because we'll need to access them from other chunks) * add clearcoat parameters to standard material * use shader chunks when clear coat is enabled * add pc.StandardMaterial#clearCoatBumpiness * document new clear coat properties * add support for KHR_materials_clearcoat in gltf parser * add temp workaround for replicating glTF clear-coat visuals * minor documentation tweak Co-authored-by: Ray Tran <raytranuk@users.noreply.github.com> commit 4d5f59d Author: Aidin Abedi <aidinabedi@gmail.com> Date: Thu Aug 27 19:52:59 2020 +0200 Fix normals when mesh has both two-sided material and negative scale (#2375) * fix: flip back-facing normals for double-sided materials depending on their angle towards the eye the original method of using gl_FrontFacing doesn't work for mirrored geometry * refactor: rename normalSign to normalDirSign Co-authored-by: Anders Gallon <anders.gallon@animech.com> commit 8600fc6 Author: Elliott Thompson <ellth92@gmail.com> Date: Thu Aug 27 16:05:05 2020 +0100 updates the anim component to accept transitions that have their source state set to any state (#2390) commit 6ee5309 Author: Martin Valigursky <59932779+mvaligursky@users.noreply.github.com> Date: Thu Aug 27 11:38:36 2020 +0100 MeshInstance frustum culling - small refactor (#2389) * MeshInstance frustum culling - small refactor * creating BoundingSphere instead of object with similar properties * removed unnecessary parameters commit c8c9b92 Author: zachpeterpaul <49728898+zachpeterpaul@users.noreply.github.com> Date: Wed Aug 26 16:41:02 2020 -0700 set entity._template to true for template root (#2384) Co-authored-by: zachppaul <zachppaul@gmail.com> commit 7b9177d Author: Martin Valigursky <59932779+mvaligursky@users.noreply.github.com> Date: Wed Aug 26 15:03:44 2020 +0100 [Fix] Texture based morphing would not update when all weights are 0 (#2387) commit 5ad2185 Author: Steven <yaustar@users.noreply.github.com> Date: Tue Aug 25 11:08:18 2020 +0100 Add hit-test to optional XR features (#2381) Fixes hit-test when launched on hand held device Co-authored-by: Steven Yau <syau@snaphcat.com> commit 8fbea05 Author: Will Eastcott <will@playcanvas.com> Date: Thu Aug 20 11:11:29 2020 +0100 Update NPM dependencies (#2370) * Update NPM dependencies * Lint fix commit c1b132b Author: Donovan Hutchence <slimbuck7@gmail.com> Date: Wed Aug 19 16:18:23 2020 +0100 [VERSION] v1.35.0-dev commit 71086a3 Author: Donovan Hutchence <slimbuck7@gmail.com> Date: Wed Aug 19 16:18:23 2020 +0100 [RELEASE] v1.34.0 commit d8113fd Author: Donovan Hutchence <slimbuck7@gmail.com> Date: Wed Aug 19 14:22:43 2020 +0100 [FIX] Compile fix (#2368) * compile fix * run build:all during ci checks commit 0626613 Author: Donovan Hutchence <slimbuck7@gmail.com> Date: Wed Aug 19 11:05:48 2020 +0100 add test when patching container multiple times (#2367) commit d1f1555 Author: Vaios Kalpias Ilias <vkalpias@gmail.com> Date: Wed Aug 19 02:25:50 2020 -0700 Add documentation for pc.Element#mask (#2366) commit 3a3d41c Author: Elliott Thompson <ellth92@gmail.com> Date: Wed Aug 19 10:25:28 2020 +0100 Anim optimizations (#2354) * optimize the setting of animated properties in the anim binder commit d103cec Author: Steven <yaustar@users.noreply.github.com> Date: Wed Aug 19 10:24:36 2020 +0100 Added example code for curve and curve set (#2353) * Added example code for curve and curve set Also fixes: playcanvas/developer.playcanvas.com#119 * Fixed lint * Fixed example spacing again * Reverted change to gampad on xrinput Co-authored-by: Steven Yau <syau@snaphcat.com> commit e51cf8e Author: Donovan Hutchence <slimbuck7@gmail.com> Date: Tue Aug 18 19:05:06 2020 +0100 Specify basis URL config (#2359) * construct node hierarchy even when no model exists commit 8e47386 Author: Donovan Hutchence <slimbuck7@gmail.com> Date: Tue Aug 18 18:19:58 2020 +0100 construct node hierarchy even when no model exists (#2358) commit bb94f0d Author: Vaios Kalpias Ilias <vkalpias@gmail.com> Date: Mon Aug 17 11:10:06 2020 -0700 Adding support for json script attributes with a schema (1 level deep) (#2234) commit e53818f Author: Martin Valigursky <59932779+mvaligursky@users.noreply.github.com> Date: Tue Aug 11 16:24:15 2020 +0100 [Fix] Glb converts 32bit index buffer to 16 if device does not support it (#2349) * [Fix] Glb converts 32bit index buffer to 16 if device does not support it * simpler code commit 0b529cb Author: Martin Valigursky <59932779+mvaligursky@users.noreply.github.com> Date: Tue Aug 11 16:23:07 2020 +0100 [Fix] gpu size calculation for PIXELFORMAT_L8_A8 and mipmaps (#2350) * [Fix] gpu size calculation for PIXELFORMAT_L8_A8 and mipmaps * lint fix commit 75cebd3 Author: Benjamin Cabé <kartben@users.noreply.github.com> Date: Tue Aug 11 09:52:29 2020 +0200 Fix spelling for Arm (#2344) commit ea66160 Author: Martin Valigursky <59932779+mvaligursky@users.noreply.github.com> Date: Mon Aug 10 15:16:47 2020 +0100 [Fix] improve compatibility of example with older mobile devices (#2348) commit 3e9ccc9 Author: Martin Valigursky <59932779+mvaligursky@users.noreply.github.com> Date: Mon Aug 10 14:27:44 2020 +0100 [Fix] Mini-stats uses 16bit index buffer insead of 32 (#2347) - makes it compatible with devices which dont support 32bit indices * skin instance import fix * build fixes * Squashed commit of the following: commit ad6fd49 Author: Elliott Thompson <ellth92@gmail.com> Date: Fri Sep 18 15:14:20 2020 +0100 update the anim controller update function to fix certain transition states (#2434) commit 3b9983c Author: Martin Valigursky <59932779+mvaligursky@users.noreply.github.com> Date: Thu Sep 17 17:57:11 2020 +0100 Mini-stats update with functionality and flexibility (#2428) * Mini-stats - separated file into per-class files. * fixed typo in comment * implemented new features * lint fix * small improvements * small changes (white text, black clear color, smaller gaps between graphs) * text labels are slightly darker than numbers * tracking basic frame timing and drawCall count even in release build * spacing updates * black background when graph is disabled * size adjustement commit 5389039 Author: moka <core@moka.co> Date: Wed Sep 16 00:03:00 2020 +0200 [FIX] tags remove error (#2432) commit 4b711a7 Author: imgbot[bot] <31301654+imgbot[bot]@users.noreply.github.com> Date: Tue Sep 15 16:29:08 2020 +0100 [ImgBot] Optimize images (#2430) /examples/assets/textures/normal-map.png -- 736.03kb -> 595.91kb (19.04%) Signed-off-by: ImgBotApp <ImgBotHelp@gmail.com> Co-authored-by: ImgBotApp <ImgBotHelp@gmail.com> commit 0f14984 Author: Martin Valigursky <59932779+mvaligursky@users.noreply.github.com> Date: Tue Sep 15 15:18:30 2020 +0100 Refraction engine example and small related engine fix (#2429) * Refraction engine example and small related engine fix * small change in how grab texture is set up to only use public interface * offset centering * using mesh UVs to sample offset texture instead of screen position * renamed to grab-pass commit 5b82eb9 Author: moka <core@moka.co> Date: Thu Sep 10 18:58:56 2020 +0200 expose session and frame for WebXR (#2422) commit 8746592 Author: Ray Tran <raytranuk@users.noreply.github.com> Date: Wed Sep 9 09:54:37 2020 +0100 Warning added when element input is enabled, but no pc.ElementInput is created to fire input events (#2419) Warning added when element input is enabled, but no pc.ElementInput is created to fire input events This will greatly help debugging a problem I wasted hours on - where element input event were not firing without any indication of why. commit 6279a2b Author: Martin Valigursky <59932779+mvaligursky@users.noreply.github.com> Date: Tue Sep 8 19:26:46 2020 +0100 Frustum culling on camera created by code defaults to true (#2415) commit f2476b3 Author: Donovan Hutchence <slimbuck7@gmail.com> Date: Tue Sep 8 15:32:06 2020 +0100 [VERSION] v1.36.0-dev commit 100604b Author: Donovan Hutchence <slimbuck7@gmail.com> Date: Tue Sep 8 15:32:06 2020 +0100 [RELEASE] v1.35.0 commit e5d6bca Author: Martin Valigursky <59932779+mvaligursky@users.noreply.github.com> Date: Mon Sep 7 16:21:26 2020 +0100 [Fix] Supporting pass specific mesh-instance parameters as they are used by the Editor (#2411) commit e129194 Author: Donovan Hutchence <slimbuck7@gmail.com> Date: Mon Sep 7 12:17:08 2020 +0100 Simplify binder logic (#2401) * simplify binder * invoke setter when driving vector members commit 9cedb85 Author: Ray Tran <raytranuk@users.noreply.github.com> Date: Fri Sep 4 17:08:39 2020 +0100 Revert "Fix normals when mesh has both two-sided material and negative scale (#2375)" (#2406) This reverts commit 4d5f59d. # Conflicts: # src/graphics/program-lib/programs/standard.js commit 55e477a Author: Martin Valigursky <59932779+mvaligursky@users.noreply.github.com> Date: Fri Sep 4 15:06:39 2020 +0100 [Fix] Fixing return type of Entity.findComponents to be an array (#2405) commit 0e3022c Author: zachpeterpaul <49728898+zachpeterpaul@users.noreply.github.com> Date: Wed Sep 2 10:24:11 2020 -0700 Support for a more compressed scene file format (#2294) * initial decompress * do nothing without the compressed field * move decompress data * decompress in template * decompress in hierarchy * use underscores with private vars * rm else return * refactor parser for speed * rm expanding entities in templates * decompress entities only * move decompress to scene parser * initial decompress * handle triple vectors * reorder array and map check * change map check * rename fields * use field map array * edits for lint * comments in decompress * move decompress call to parser * add utils comments Co-authored-by: zachppaul <zachppaul@gmail.com> * Squashed commit of the following: commit d369b82 Author: Martin Valigursky <59932779+mvaligursky@users.noreply.github.com> Date: Wed Oct 7 10:58:40 2020 +0100 Optimized culling solution for skinned meshes (#2435) * ModelComponent can specify oversize bounding box and disable expensive skinned bounds update * es5 compatibility commit f1692a6 Author: Will Eastcott <will@playcanvas.com> Date: Mon Oct 5 20:44:34 2020 +0100 [FIX] Minor corrections to Typescript definitions (#2459) * [FIX] Minor corrections to Typescript definitions * Handle all function signatures for pc.Tags commit 524aeb0 Author: Elliott Thompson <ellth92@gmail.com> Date: Thu Oct 1 17:43:09 2020 +0100 update transition offset jsdoc and fix the state timeline duration property (#2457) commit bcf1b3f Author: Elliott Thompson <ellth92@gmail.com> Date: Thu Oct 1 16:47:06 2020 +0100 AnimComponent - Blend Trees (#2443) * anim component - blend trees commit b2243ff Author: moka <core@moka.co> Date: Wed Sep 30 16:12:52 2020 +0300 add particle define to particle shaders (#2454) commit 7630827 Author: Steven <yaustar@users.noreply.github.com> Date: Tue Sep 29 16:59:02 2020 +0100 Call upgradeDataSchema if there is no error (#2450) Co-authored-by: Steven Yau <syau@snaphcat.com> commit db49fe8 Author: moka <core@moka.co> Date: Tue Sep 29 18:58:52 2020 +0300 WebXR optionalFeatures options and change to `start` method (#2397) * WebXR optionalFeatures options and change to `start` method * corrections commit 7e0f0a5 Author: Donovan Hutchence <slimbuck7@gmail.com> Date: Tue Sep 29 12:43:32 2020 +0100 [VERSION] v1.36.0-dev commit 3317bcf Author: Donovan Hutchence <slimbuck7@gmail.com> Date: Tue Sep 29 12:43:32 2020 +0100 [RELEASE] v1.35.1 commit a617df9 Author: Steven <yaustar@users.noreply.github.com> Date: Fri Sep 25 14:29:33 2020 +0100 Removes global data when Component System is destroyed (#2448) Fixes #2442 Co-authored-by: Steven Yau <syau@snaphcat.com> commit 0a22646 Author: Martin Valigursky <59932779+mvaligursky@users.noreply.github.com> Date: Fri Sep 25 09:59:17 2020 +0100 Fix for instanced rendering VB setup for the second eye in VR (#2446) commit 06b6e2f Author: Kotov Oleg <oleg.sveshnickov@yandex.ru> Date: Tue Sep 22 03:06:43 2020 +0300 [FIX] Copy paste typo in Vec2 and Vec3 classes (#2436) * Update vec2.js Documentation copypasta fix * Update vec3.js commit ad6fd49 Author: Elliott Thompson <ellth92@gmail.com> Date: Fri Sep 18 15:14:20 2020 +0100 update the anim controller update function to fix certain transition states (#2434) commit 3b9983c Author: Martin Valigursky <59932779+mvaligursky@users.noreply.github.com> Date: Thu Sep 17 17:57:11 2020 +0100 Mini-stats update with functionality and flexibility (#2428) * Mini-stats - separated file into per-class files. * fixed typo in comment * implemented new features * lint fix * small improvements * small changes (white text, black clear color, smaller gaps between graphs) * text labels are slightly darker than numbers * tracking basic frame timing and drawCall count even in release build * spacing updates * black background when graph is disabled * size adjustement commit 5389039 Author: moka <core@moka.co> Date: Wed Sep 16 00:03:00 2020 +0200 [FIX] tags remove error (#2432) commit 4b711a7 Author: imgbot[bot] <31301654+imgbot[bot]@users.noreply.github.com> Date: Tue Sep 15 16:29:08 2020 +0100 [ImgBot] Optimize images (#2430) /examples/assets/textures/normal-map.png -- 736.03kb -> 595.91kb (19.04%) Signed-off-by: ImgBotApp <ImgBotHelp@gmail.com> Co-authored-by: ImgBotApp <ImgBotHelp@gmail.com> commit 0f14984 Author: Martin Valigursky <59932779+mvaligursky@users.noreply.github.com> Date: Tue Sep 15 15:18:30 2020 +0100 Refraction engine example and small related engine fix (#2429) * Refraction engine example and small related engine fix * small change in how grab texture is set up to only use public interface * offset centering * using mesh UVs to sample offset texture instead of screen position * renamed to grab-pass commit 5b82eb9 Author: moka <core@moka.co> Date: Thu Sep 10 18:58:56 2020 +0200 expose session and frame for WebXR (#2422) commit 8746592 Author: Ray Tran <raytranuk@users.noreply.github.com> Date: Wed Sep 9 09:54:37 2020 +0100 Warning added when element input is enabled, but no pc.ElementInput is created to fire input events (#2419) Warning added when element input is enabled, but no pc.ElementInput is created to fire input events This will greatly help debugging a problem I wasted hours on - where element input event were not firing without any indication of why. commit 6279a2b Author: Martin Valigursky <59932779+mvaligursky@users.noreply.github.com> Date: Tue Sep 8 19:26:46 2020 +0100 Frustum culling on camera created by code defaults to true (#2415) commit f2476b3 Author: Donovan Hutchence <slimbuck7@gmail.com> Date: Tue Sep 8 15:32:06 2020 +0100 [VERSION] v1.36.0-dev commit 100604b Author: Donovan Hutchence <slimbuck7@gmail.com> Date: Tue Sep 8 15:32:06 2020 +0100 [RELEASE] v1.35.0 commit e5d6bca Author: Martin Valigursky <59932779+mvaligursky@users.noreply.github.com> Date: Mon Sep 7 16:21:26 2020 +0100 [Fix] Supporting pass specific mesh-instance parameters as they are used by the Editor (#2411) commit e129194 Author: Donovan Hutchence <slimbuck7@gmail.com> Date: Mon Sep 7 12:17:08 2020 +0100 Simplify binder logic (#2401) * simplify binder * invoke setter when driving vector members commit 9cedb85 Author: Ray Tran <raytranuk@users.noreply.github.com> Date: Fri Sep 4 17:08:39 2020 +0100 Revert "Fix normals when mesh has both two-sided material and negative scale (#2375)" (#2406) This reverts commit 4d5f59d. # Conflicts: # src/graphics/program-lib/programs/standard.js commit 55e477a Author: Martin Valigursky <59932779+mvaligursky@users.noreply.github.com> Date: Fri Sep 4 15:06:39 2020 +0100 [Fix] Fixing return type of Entity.findComponents to be an array (#2405) commit 0e3022c Author: zachpeterpaul <49728898+zachpeterpaul@users.noreply.github.com> Date: Wed Sep 2 10:24:11 2020 -0700 Support for a more compressed scene file format (#2294) * initial decompress * do nothing without the compressed field * move decompress data * decompress in template * decompress in hierarchy * use underscores with private vars * rm else return * refactor parser for speed * rm expanding entities in templates * decompress entities only * move decompress to scene parser * initial decompress * handle triple vectors * reorder array and map check * change map check * rename fields * use field map array * edits for lint * comments in decompress * move decompress call to parser * add utils comments Co-authored-by: zachppaul <zachppaul@gmail.com> * render component support for override aabb * render asset + loading, WIP * small fix * asset property on render component * fix to render component * Fix asset loading for render component and relevant assets * Remove mesh instances when render asset is removed or unloaded * Fix meshInstances set when changing render type * clean up * Fix render asset example * Lint fixes * render.material support is back * update to material property * Documented asset, materialAssets for render component * render component engine examples - new baking example showing render component baking support�, adjusted few other examples to use render component * meshinstance cleanup * clear assets on remove * clean up meshInstances when changing asset type * single block for all properties * Reset to default material if necessary * Always create materialReferences even if value of materialAssets[i] is null * Switch to materialAssets[0] when the type changes unless 'material' has been set to something other than the default material * comment fixes, memory release improvement * Fix comment * Various fixes for render asset loader * Handle container asset remove * Added RenderComponent#rootBone and fixed some issues with cloning render components * Added docs for rootBone * spacing * find root bone in postInitialize * fixing glb-loader not calling callback when there are not buffers to load * skin and morph instances created when render component connects to render asset * fixed rootBone test * missing morph instance import * handles texture removal from asset that is not loaded by checking for null * fixing inheritance for skin batch instance * fix to render component asset release when type changes * Subscribe to set:meshes event using 'on' not 'once' * null check * comment improvement * one space less * Resolve rootBone entities in RenderComponentSystem's postInitialize * moved empty glb handling to separte glb to release earlier * unused import * removed empty line * comment improvement * added comments * improved model cleanup * Fire set:entity event in EntityReference when entity changes, Use EntityReference for render component's rootBone * function rename: _onRootBoneChanged * comment typo fix Co-authored-by: Will Eastcott <will@playcanvas.com> * documentation name fix * removed engine examples from this PR, those are in separate PR now Co-authored-by: Vaios Kalpias Ilias <vkalpias@gmail.com> Co-authored-by: Will Eastcott <will@playcanvas.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When asset is removed (easy to test in Editor), if it had tags, then it should be removed from tags index on asset registry. This small error been sitting there for very long time (5 years actually). Well, looks like removing assets from asset registry with tags is a rare case.
I confirm I have signed the Contributor License Agreement.