Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Screen Space Ambient Occlusion post effect #3266

Merged
merged 7 commits into from
Jun 28, 2021
Merged

Screen Space Ambient Occlusion post effect #3266

merged 7 commits into from
Jun 28, 2021

Conversation

mvaligursky
Copy link
Contributor

@mvaligursky mvaligursky commented Jun 25, 2021 •
edited

Fixes: #1136
Based on #3092, thank you to @raytranuk for an excellent contribution. This PR in addition to the initial PR exposed few parameters and did few small changes related to parameters. I also make it to work on Webgl1.

The implementation is based on the code in Filament Engine: https://github.com/google/filament

Screenshot 2021-06-25 at 13 16 39

example of using the effect on a camera:

camera.addComponent("script");
camera.script.create("ssao", {
    attributes: {
        radius: 5,
        samples: 16,
        brightness: 0
    }
});

@mvaligursky mvaligursky mentioned this pull request Jun 25, 2021
Closed
@mvaligursky mvaligursky self-assigned this Jun 25, 2021
willeastcott
willeastcott reviewed Jun 26, 2021
View reviewed changes
scripts/posteffects/posteffect-ssao.js

scope.resolve("uSSAOBuffer").setValue(this.targets[0].colorBuffer);

// scope.resolve("uFarPlaneOverEdgeDistance").setValue(cameraFarClip / bilateralThreshold);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete this line if not required?

willeastcott
willeastcott approved these changes Jun 26, 2021
View reviewed changes
Copy link
Contributor

@willeastcott willeastcott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with various suggestions and comments.

mvaligursky and others added 5 commits June 28, 2021 01:46
@mvaligursky @willeastcott
Update scripts/posteffects/posteffect-ssao.js
e174f31 
Co-authored-by: Will Eastcott <will@playcanvas.com>
@mvaligursky @willeastcott
Update scripts/posteffects/posteffect-ssao.js
85cb522 
Co-authored-by: Will Eastcott <will@playcanvas.com>
@mvaligursky @willeastcott
Apply suggestions from code review
8553dec 
Co-authored-by: Will Eastcott <will@playcanvas.com>
removed loop of 1 iteration
df0479e
removed unused code, got it to work for webgl1
8ed4d08
@mvaligursky mvaligursky merged commit d056579 into master Jun 28, 2021
@mvaligursky mvaligursky deleted the mvaligursky-ssao branch June 28, 2021 11:06
@Maksims
Copy link
Contributor

Maksims commented Jun 28, 2021

Can please the shader code be moved to a separate file? Making it more usable than it is when written within JS?
Editor users don't have the easy ability to copy it.

@mvaligursky
Copy link
Contributor Author

I agree it's not ideal, but it matches the style of all post effects - it's a single file with all shaders inlined.
But definitely something to consider for the future, we have plans for the next generation of post effects (including node graph support and similar).

@animech-sijo animech-sijo mentioned this pull request Nov 14, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willeastcott willeastcott willeastcott approved these changes

@slimbuck slimbuck Awaiting requested review from slimbuck

@ellthompson ellthompson Awaiting requested review from ellthompson

Assignees

@mvaligursky mvaligursky

Labels
area: graphics Graphics related issue feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Post-processed Ambient Occlusion
4 participants
@mvaligursky @Maksims @willeastcott @ellthompson