Conversation
|
@mvaligursky Looks great! Can you please help a tiny bit? I've grabbed the JS file, added it to PC, popped it onto my camera, and the effect does not seem to work at all. Does it require any additional task to get it up and running? |
Contributor
|
That should be all needed, but I'm not 100% sure as I wasn't involved in this. It's possible an engine release was needed for this to work .. could you please try again now that the engine was released last week. |
Contributor
|
closing due to follow up PR: #3266 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes: #1136
This PR includes a Post Process SSAO implementation based on and ported from Filament's excellent implementation.
NB: Future work may include applying SSAO more correctly only on ambient light
I confirm I have signed the Contributor License Agreement.