Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Glb parser handles a scene without nodes #3677

Merged
merged 1 commit into from
Nov 9, 2021
Merged

[Fix] Glb parser handles a scene without nodes #3677

merged 1 commit into from
Nov 9, 2021

Conversation

mvaligursky
Copy link
Contributor

@mvaligursky mvaligursky commented Nov 9, 2021 •
edited
Loading

@mvaligursky mvaligursky self-assigned this Nov 9, 2021
@mvaligursky mvaligursky requested a review from a team November 9, 2021 13:48
slimbuck
slimbuck reviewed Nov 9, 2021
View reviewed changes
Copy link
Member

@slimbuck slimbuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this handling an empty gltf file, or can the file contain other assets without a single node?

@mvaligursky
Copy link
Contributor Author

is this handling an empty gltf file, or can the file contain other assets without a single node?

We already handled empty file before.
This handles a case where there are two or more scenes, and some don't have any nodes.

@mvaligursky mvaligursky merged commit 5bc42ff into dev Nov 9, 2021
@mvaligursky mvaligursky deleted the mvaligursky-glb-null-scene-node branch November 9, 2021 13:59
slimbuck pushed a commit that referenced this pull request Nov 10, 2021
@mvaligursky @slimbuck
[Fix] Glb parser handles a scene without nodes (#3677)
8a0ec97 
Co-authored-by: Martin Valigursky <mvaligursky@snapchat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slimbuck slimbuck slimbuck left review comments

@willeastcott willeastcott willeastcott approved these changes

Assignees

@mvaligursky mvaligursky

Labels
area: gltf bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mvaligursky @willeastcott @slimbuck