Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Correct type of AnimClip eventHandler parameter #4166

Merged
merged 1 commit into from
Apr 4, 2022
Merged

[FIX] Correct type of AnimClip eventHandler parameter #4166

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/anim/evaluator/anim-clip.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import { AnimSnapshot } from './anim-snapshot.js';

/** @typedef {import('./anim-track.js').AnimTrack} AnimTrack */
/** @typedef {import('../../core/event-handler.js').EventHandler} EventHandler */

// TODO: add configurable looping start/end times?

Expand All @@ -19,7 +20,7 @@ class AnimClip {
* @param {number} speed - Speed of the animation playback.
* @param {boolean} playing - true if the clip is playing and false otherwise.
* @param {boolean} loop - Whether the clip should loop.
* @param {Function} eventHandler - The handler to call when an event is fired by the clip.
* @param {EventHandler} [eventHandler] - The handler to call when an event is fired by the clip.
*/
constructor(track, time, speed, playing, loop, eventHandler) {
this._name = track.name; // default to track name
Expand Down