Make touch events passive like mouse events

[erikdubbelboer]

Prevent console messages like:

[Violation] Added non-passive event listener to a scroll-blocking 'touchmove' event. Consider marking event handler as 'passive' to make the page more responsive. See https://www.chromestatus.com/feature/5745543795965952

See also:

engine/src/input/element-input.js

Lines 421 to 426 in 9a0697c

	const opts = platform.passiveEvents ? { passive: true } : false;
	if (this._useMouse) {
	window.addEventListener('mouseup', this._upHandler, opts);
	window.addEventListener('mousedown', this._downHandler, opts);
	window.addEventListener('mousemove', this._moveHandler, opts);
	window.addEventListener('wheel', this._wheelHandler, opts);

I confirm I have read the contributing guidelines and signed the Contributor License Agreement.

[willeastcott]

The mouse module sets the third parameter of removeEventListener as well as addEventListener. Presumably, touch should do the same?

PR might need to change calls to removeEventListener

[erikdubbelboer]

That's giving me linting errors as passive is not a valid option for removeEventListener. See: https://developer.mozilla.org/en-US/docs/Web/API/EventTarget/removeEventListener#options
You want me to still add it?

I'm also getting this linting error in the mouse module:

[willeastcott]

Ah yeah, you're right. I just read this: https://developer.mozilla.org/en-US/docs/Web/API/EventTarget/removeEventListener
I'm wondering whether the best solution would be to completely drop the third parameter from the calls to removeEventListener.

[erikdubbelboer]

I would keep the false there just for clarity.

[willeastcott]

OK, sounds good. 😄