Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don’t log version/revision message if those are not valid #4421

Merged
merged 3 commits into from
Jul 11, 2022
Merged

Don’t log version/revision message if those are not valid #4421

merged 3 commits into from
Jul 11, 2022

Conversation

mvaligursky
Copy link
Contributor

@mvaligursky mvaligursky commented Jul 11, 2022 •
edited

Fixes #4420

  • don't log it if the version contains '$' which is only in the default value.

@mvaligursky mvaligursky self-assigned this Jul 11, 2022
@mvaligursky mvaligursky merged commit c3718a0 into main Jul 11, 2022
@mvaligursky mvaligursky deleted the mvaligursky-revision-logging branch July 11, 2022 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willeastcott willeastcott willeastcott approved these changes

@yaustar yaustar Awaiting requested review from yaustar

@slimbuck slimbuck Awaiting requested review from slimbuck

Assignees

@mvaligursky mvaligursky

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve 'Powered by PlayCanvas' log message
2 participants
@mvaligursky @willeastcott