Add switch to enable/disable specular color with metalness workflow #4428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GSterbrant
changed the title
mvaligursky
reviewed
Jul 13, 2022
slimbuck
reviewed
Jul 13, 2022
I added tint as to not confuse it with enabling/disabling specular with metalness workflow.
|
Decided to call it useMetalnessSpecularTint as to not make it sound like it's used to enable/disable specular effects with metalness. |
slimbuck
reviewed
Jul 13, 2022
Co-authored-by: Donovan Hutchence <slimbuck7@gmail.com>
slimbuck
reviewed
Jul 13, 2022
…hey were related but are actually separate.
…om:playcanvas/engine into gsterbrant_metalness_specular_color_switch
Co-authored-by: Donovan Hutchence <slimbuck7@gmail.com>
mvaligursky
approved these changes
Jul 13, 2022
There was a problem hiding this comment.
Looks great, should work well.
Please wait for @slimbuck 's review as well.
Because we have specular maps which will be used if assigned, we need some way to turn off the specular colours on the shader level instead of just controlling the tint. Changed name of the useMetalnessSpecularTint to useMetalnessSpecularColor.
…calculation in the shader.
slimbuck
approved these changes
Jul 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The metalness workflow recently exposed specular color modulation for F0 reflections, however it caused some issues related to default specular color. This PR addresses this issue by adding a switch which explicitly enables specular tinting with metalness, forcing users who want this feature to first turn the flag on, and then assign specular color values.
Relates to #4423 #4386 and #4419.