[BREAKING] Material specular now defaults to 1. #4419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slimbuck
approved these changes
Jul 11, 2022
This will enable specular on objects that might've not had it before (objects not using the metalness workflow) but will avoid weird effects where specularity disappears on materials with metalness.
GSterbrant
changed the title
GSterbrant
changed the title
mvaligursky
approved these changes
Jul 11, 2022
GSterbrant
changed the title
GSterbrant
changed the title
This was referenced Jul 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Materials using metalness, will, due to #4386 use the specular color to tint specular and environment reflections. However, since specular is default 0, specular effects would disappear with metalness materials. If this is indeed the desired outcome, just set the specular color to 0 like so:
material.specular = new pc.Color(0, 0, 0);This PR also fixes an issue with the specular fade seen here:
Previously:
After fix:
