Only degamma specular if we use a metalness specular color map #4436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GSterbrant
changed the title
GSterbrant
force-pushed
the
gsterbrant_degamma_specular_fix
branch
from
33d1a72
to
b40afce
Compare
slimbuck
reviewed
Jul 15, 2022
| @@ -339,7 +339,7 @@ const standard = { | |||
| func.append("getSpecularityFactor();"); | |||
| } | |||
| if (options.useSpecularColor) { | |||
| code.append(this._addMap("specular", "specularPS", options, litShader.chunks)); | |||
| code.append(this._addMap("specular", "specularPS", options, litShader.chunks, options.specularEncoding)); | |||
There was a problem hiding this comment.
I think we want this:
Suggested change
| code.append(this._addMap("specular", "specularPS", options, litShader.chunks, options.specularEncoding)); | |
| code.append(this._addMap("specular", "specularPS", options, litShader.chunks, options.useMetalness ? 'srgb' : 'linear')); |
… in the frontend directly.
…as/engine into gsterbrant_degamma_specular_fix
slimbuck
approved these changes
Jul 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Specular should only apply degamma when using specular maps in the metalness workflow.