Handle shader-decoded texture alpha correctly #4440
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a shader compile error resulting from user choosing the alpha channel of a decoded texture. (This is because the decoding step takes a vec4 and returns a vec3 so alpha doesn't exist).
Since there is never actual decoding of texture alpha (i.e. gamma textures don't correct alpha and RGBM/P/E textures use alpha channel to reconstruct RGB) we just add a passthrough for this case instead.
Also move
textureSample.js
chunk to the correct location.