Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support extension declarations in shader preprocessor #4476

Merged
merged 2 commits into from
Jul 25, 2022

Conversation

slimbuck
Copy link
Member

Fixes #4465

The shader preprocessor wasn't handling extension defines and was removing code blocks guarded by extensions.

@slimbuck slimbuck added bug area: graphics Graphics related issue labels Jul 25, 2022
@slimbuck slimbuck requested a review from a team July 25, 2022 11:57
@slimbuck slimbuck self-assigned this Jul 25, 2022
@slimbuck slimbuck merged commit 1d3da63 into playcanvas:main Jul 25, 2022
@slimbuck slimbuck deleted the preprocessor-fix branch July 25, 2022 13:03
slimbuck added a commit that referenced this pull request Aug 1, 2022
* add support for extensions in the preprocessor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: graphics Graphics related issue bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Text elements look blurry with forced WebGL1 since engine 1.54
2 participants