Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] remove extraneous bracket in diffuseDetailMap shader chunk #4481

Merged
merged 1 commit into from Jul 26, 2022

Conversation

Mintytorus
Copy link
Contributor

This fixes shader compilation for materials that use diffuseDetailMap textures

I confirm I have read the contributing guidelines and signed the Contributor License Agreement.

@yaustar yaustar requested review from slimbuck, GSterbrant and a team July 26, 2022 16:12
@willeastcott
Copy link
Contributor

Well spotted! 👍

Copy link
Member

@slimbuck slimbuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing, thanks for fixing my bugs!

@slimbuck slimbuck merged commit c395324 into playcanvas:main Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants