Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve render target before generating mips #4661

Merged
merged 1 commit into from Sep 23, 2022
Merged

Resolve render target before generating mips #4661

merged 1 commit into from Sep 23, 2022

Conversation

slimbuck
Copy link
Member

@slimbuck slimbuck commented Sep 23, 2022 •
edited by willeastcott

Makes sense to resolve render target before generating its texture mipmaps.

@slimbuck slimbuck added enhancement area: graphics Graphics related issue labels Sep 23, 2022
@slimbuck slimbuck requested a review from a team September 23, 2022 09:24
@slimbuck slimbuck self-assigned this Sep 23, 2022
mvaligursky
mvaligursky approved these changes Sep 23, 2022
View reviewed changes
Copy link
Contributor

@mvaligursky mvaligursky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. Please test with at least post-effect engine example to make sure that works fine.

@slimbuck slimbuck merged commit 637e2f0 into playcanvas:main Sep 23, 2022
@slimbuck slimbuck deleted the resolve-first branch September 23, 2022 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvaligursky mvaligursky mvaligursky approved these changes

Assignees

@slimbuck slimbuck

Labels
area: graphics Graphics related issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@slimbuck @mvaligursky