Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve render target before generating mips #4661

Merged
merged 1 commit into from
Sep 23, 2022
Merged

Resolve render target before generating mips #4661

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/graphics/webgl/webgl-graphics-device.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1438,6 +1438,11 @@ class WebglGraphicsDevice extends GraphicsDevice {
// Unset the render target
const target = this.renderTarget;
if (target) {
// Resolve MSAA if needed
if (this.webgl2 && target._samples > 1 && target.autoResolve) {
target.resolve();
}

// If the active render target is auto-mipmapped, generate its mip chain
const colorBuffer = target._colorBuffer;
if (colorBuffer && colorBuffer.impl._glTexture && colorBuffer.mipmaps && (colorBuffer.pot || this.webgl2)) {
Expand All @@ -1447,11 +1452,6 @@ class WebglGraphicsDevice extends GraphicsDevice {
this.bindTexture(colorBuffer);
this.gl.generateMipmap(colorBuffer.impl._glTarget);
}

// Resolve MSAA if needed
if (this.webgl2 && target._samples > 1 && target.autoResolve) {
target.resolve();
}
}

DebugGraphics.popGpuMarker(this);
Expand Down