Element Drag Helper - Screen to Local gives wrong values if parent is scaled #4935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willeastcott
approved these changes
Dec 19, 2022
|
Nice fix! 👍 |
|
Please reconsider, this should break #3748 again |
|
Confirmed it does break #3748 again which leaves us in a problem. I will investigate more |
|
@kungfooman The current fix I can think of for both issues is to 0 out the local Z position from _screenToLocal Test projects: See: c72be6a |
This was referenced Dec 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4934
_screenToLocalwas using localPosition which meant if the parent of the element is scaled and not at 0, 0, 0 (which is the case for most 3D screens where the default is 0.01 scale), the plane position would be in the wrong positionThen the calculated intersection would be incorrect and the local Z value would change
I confirm I have read the contributing guidelines and signed the Contributor License Agreement.