Fix regression of world space drag bug #3748 #4937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willeastcott
approved these changes
Dec 19, 2022
|
Wow, thank you for fixing this so quickly! I would love to properly test it, but it takes some time and I'm in the process of finishing something else rn, so I could do it tomorrow |
|
Yeah, tomorrow or later this week is fine :) |
|
I tested this in different circumstances and it works perfectly, great job 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3748
PR #4935 reintroduces the bug #3748
This PR zeros out the local Z translation of the drag in
_screenToLocalso that the element can only move along it's local Y and X axis1.59
Kapture.2022-12-19.at.15.54.13.mp4
With this PR and #4935
Kapture.2022-12-19.at.15.54.51.mp4
CC @kungfooman
I confirm I have read the contributing guidelines and signed the Contributor License Agreement.