[Anim Component] Fix exit time conditions for non looping animations #5426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… times when progress has stopped
mvaligursky
reviewed
Jun 21, 2023
mvaligursky
reviewed
Jun 21, 2023
| maxDuration = Math.max(maxDuration, activeClip.track.duration); | ||
| if (this._activeStateDurationDirty) { | ||
| if (this.activeStateName === ANIM_STATE_START || this.activeStateName === ANIM_STATE_END) | ||
| return 0.0; |
There was a problem hiding this comment.
this should probably update _activeStateDuration instead of just returning 0
mvaligursky
approved these changes
Jun 22, 2023
slimbuck
pushed a commit
that referenced
this pull request
Jun 22, 2023
…5426) * anim component - cap the active time of the non looping states to their duration and check for exit times when progress has stopped
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The anim controller shouldn't update the state time when a non looping animation has completed its playback. Additionally states that have finished their playback should have their exit time conditions checked as if they were playing.
Fixes #4427
I confirm I have read the contributing guidelines and signed the Contributor License Agreement.