New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding browser check before calling Spector #5874

Merged

marklundin merged 1 commit into main from window-check

Dec 1, 2023

Member

marklundin commented Dec 1, 2023

When running tests in node, we need to avoid calls to 'window'. This simply adds a browser check to the Spector push and popMarker

I confirm I have read the contributing guidelines and signed the Contributor License Agreement.


          Adding browser check before including Spector call

07c78a7

marklundin requested a review from mvaligursky

December 1, 2023 16:05

mvaligursky approved these changes

View reviewed changes

marklundin merged commit e89835a into main

7 checks passed

marklundin deleted the window-check branch

March 8, 2024 09:41

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment