Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow menu items with no onSelect function #244

Merged
merged 1 commit into from
Jan 5, 2023
Merged

Allow menu items with no onSelect function #244

merged 1 commit into from
Jan 5, 2023

Conversation

willeastcott
Copy link
Contributor

Fixes #243

@willeastcott willeastcott added the bug Something isn't working label Jan 4, 2023
@willeastcott willeastcott requested a review from a team January 4, 2023 22:01
@willeastcott willeastcott self-assigned this Jan 4, 2023
@willeastcott willeastcott merged commit eeb1d97 into main Jan 5, 2023
@willeastcott willeastcott deleted the fix-menu-select branch January 5, 2023 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slimbuck slimbuck slimbuck approved these changes

Assignees

@willeastcott willeastcott

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clicking a MenuItem throws an exception if onSelect is undefined
2 participants
@willeastcott @slimbuck