Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove _optionValue from Label #267

Merged
merged 3 commits into from
Jan 11, 2023
Merged

Remove _optionValue from Label #267

merged 3 commits into from
Jan 11, 2023

Conversation

willeastcott
Copy link
Contributor

@willeastcott willeastcott commented Jan 11, 2023 •
edited
Loading

Currently, Label is tagged with an _optionValue property by the SelectInput property. This is messy from an architectural standpoint, and the _optionValue property even appears in the API docs. This PR refactors the code to no longer require this tagging.

Also:

  • Improves typing for SelectInputArgs#options
  • Tweaks naming for Map-like objects to make them consistent with the new _labelToValue class property. These objects should probably also be Maps but this PR does not make that change.
  • Converts some forEach calls to for..of loops

@willeastcott willeastcott added the enhancement New feature or request label Jan 11, 2023
@willeastcott willeastcott self-assigned this Jan 11, 2023
@willeastcott willeastcott merged commit 8db4977 into main Jan 11, 2023
@willeastcott willeastcott deleted the remove-optionvalue branch January 11, 2023 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ellthompson ellthompson ellthompson approved these changes

Assignees

@willeastcott willeastcott

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@willeastcott @ellthompson