Remove: flag allowSyntheticDefaultImports from ts config #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willeastcott
approved these changes
Jan 19, 2023
There was a problem hiding this comment.
Based on the answers here, I believe you're correct. Thanks for the PR!
ellthompson
approved these changes
Jan 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: by default TS dosen't allow "synthetic default imports"
Screen.Recording.2023-01-19.at.02.31.16.mp4
Local solution:
Add the line allowsynthgeticsdefaultports: true to the tsconfig.json
Global solution
Change
import React from 'react'; => import * as React from 'react';in pcui repo. This change will allow use pcui without set "allowSyntheticDefaultImports: true" flag in tsconfig.json.( if you not appruve that pr please add some message about this flag in documentation, for people who want to use pcui with typescript )