Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove: flag allowSyntheticDefaultImports from ts config #282

Merged
merged 1 commit into from
Jan 19, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ document.body.appendChild(label.dom);
If you'd like to include PCUI in your React project, you can import the individual components as follows:

```javascript
import React from 'react';
import * as React from 'react';
import ReactDOM from 'react-dom';
import { TextInput } from '@playcanvas/pcui/react';
import '@playcanvas/pcui/styles';
Expand Down
2 changes: 1 addition & 1 deletion docs/pages/2-react.markdown
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ nav_order: 3
If you are more familiar with React, you can import React elements into your own `.jsx` files and use them as follows:

```jsx
import React from 'react';
import * as React from 'react';
import ReactDOM from 'react-dom';
import { TextInput } from '@playcanvas/pcui/react';
import '@playcanvas/pcui/styles';
Expand Down
1 change: 0 additions & 1 deletion react/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
"es2019",
"dom"
],
"allowSyntheticDefaultImports" : true,
"esModuleInterop" : true,
"sourceMap": true,
"moduleResolution": "node"
Expand Down
2 changes: 1 addition & 1 deletion src/components/ArrayInput/index.stories.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React from 'react';
import * as React from 'react';

import Component from './component';
import '../../scss/index.js';
Expand Down
2 changes: 1 addition & 1 deletion src/components/BooleanInput/index.stories.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React from 'react';
import * as React from 'react';

import Component from './component';
import '../../scss/index.js';
Expand Down
2 changes: 1 addition & 1 deletion src/components/Button/component.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React from 'react';
import * as React from 'react';
import Element, { ButtonArgs } from './index';
import BaseComponent from '../Element/component';

Expand Down
2 changes: 1 addition & 1 deletion src/components/Button/index.stories.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React from 'react';
import * as React from 'react';
import Component from './component';
import '../../scss/index.js';
import { action } from '@storybook/addon-actions';
Expand Down
2 changes: 1 addition & 1 deletion src/components/Canvas/component.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React from 'react';
import * as React from 'react';
import Element, { CanvasArgs } from './index';
import BaseComponent from '../Element/component';

Expand Down
2 changes: 1 addition & 1 deletion src/components/Canvas/index.stories.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React from 'react';
import * as React from 'react';

import CanvasComponent from './component';

Expand Down
2 changes: 1 addition & 1 deletion src/components/Code/index.stories.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React from 'react';
import * as React from 'react';

import Component from './component';
import '../../scss/index.js';
Expand Down
2 changes: 1 addition & 1 deletion src/components/ColorPicker/component.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React from 'react';
import * as React from 'react';
import Element, { ColorPickerArgs } from './index';
import BaseComponent from '../Element/component';

Expand Down
2 changes: 1 addition & 1 deletion src/components/ColorPicker/index.stories.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React from 'react';
import * as React from 'react';

import ColorPickerComponent from './component';

Expand Down
2 changes: 1 addition & 1 deletion src/components/Container/component.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React from 'react';
import * as React from 'react';
import Element, { ContainerArgs } from './index';
import BaseComponent from '../Element/component';

Expand Down
2 changes: 1 addition & 1 deletion src/components/Container/index.stories.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React from 'react';
import * as React from 'react';

import Container from './component';
import Label from '../Label/component';
Expand Down
2 changes: 1 addition & 1 deletion src/components/Divider/index.stories.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React from 'react';
import * as React from 'react';

import Component from './component';
import '../../scss/index.js';
Expand Down
2 changes: 1 addition & 1 deletion src/components/Element/component.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React from 'react';
import * as React from 'react';
import Element, { ElementArgs } from './index';

/**
Expand Down
2 changes: 1 addition & 1 deletion src/components/Element/index.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { EventHandle, Events, Observer } from '@playcanvas/observer';
import React from 'react';
import * as React from 'react';
import * as pcuiClass from '../../class';

import { BindingBase } from '../../binding';
Expand Down
2 changes: 1 addition & 1 deletion src/components/GradientPicker/component.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React from 'react';
import * as React from 'react';
import Element, { GradientPickerArgs } from './index';
import BaseComponent from '../Element/component';

Expand Down
2 changes: 1 addition & 1 deletion src/components/GradientPicker/index.stories.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React from 'react';
import * as React from 'react';

import GradientPickerComponent from './component';

Expand Down
2 changes: 1 addition & 1 deletion src/components/GridView/component.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React from 'react';
import * as React from 'react';
import GridViewElement, { GridViewArgs } from './index';
import GridViewItemElement from '../GridViewItem/index';
import BaseComponent from '../Element/component';
Expand Down
2 changes: 1 addition & 1 deletion src/components/GridView/index.stories.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React from 'react';
import * as React from 'react';

import GridView from './component';
import GridViewItem from '../GridViewItem/component';
Expand Down
2 changes: 1 addition & 1 deletion src/components/InfoBox/component.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React from 'react';
import * as React from 'react';
import Element, { InfoBoxArgs } from './index';
import BaseComponent from '../Element/component';

Expand Down
2 changes: 1 addition & 1 deletion src/components/InfoBox/index.stories.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React from 'react';
import * as React from 'react';

import Component from './component';
import '../../scss/index.js';
Expand Down
2 changes: 1 addition & 1 deletion src/components/Label/component.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React from 'react';
import * as React from 'react';
import Element, { LabelArgs } from './index';
import BaseComponent from '../Element/component';

Expand Down
2 changes: 1 addition & 1 deletion src/components/Label/index.stories.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React from 'react';
import * as React from 'react';

import Component from './component';
import '../../scss/index.js';
Expand Down
2 changes: 1 addition & 1 deletion src/components/LabelGroup/index.stories.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React from 'react';
import * as React from 'react';

import Component from './component';
import '../../scss/index.js';
Expand Down
2 changes: 1 addition & 1 deletion src/components/Menu/component.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React from 'react';
import * as React from 'react';
import Element, { MenuArgs } from './index';
import BaseComponent from '../Element/component';

Expand Down
2 changes: 1 addition & 1 deletion src/components/Menu/index.stories.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React from 'react';
import * as React from 'react';

import Component from './component';
import '../../scss/index.js';
Expand Down
2 changes: 1 addition & 1 deletion src/components/NumericInput/index.stories.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React from 'react';
import * as React from 'react';

import Component from './component';
import '../../scss/index.js';
Expand Down
2 changes: 1 addition & 1 deletion src/components/Overlay/index.stories.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React from 'react';
import * as React from 'react';
import Component from './component';
import '../../scss/index.js';

Expand Down
2 changes: 1 addition & 1 deletion src/components/Panel/component.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React from 'react';
import * as React from 'react';
import Element, { PanelArgs } from './index';
import BaseComponent from '../Element/component';

Expand Down
2 changes: 1 addition & 1 deletion src/components/Panel/index.stories.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React from 'react';
import * as React from 'react';

import Component from './component';
import '../../scss/index.js';
Expand Down
2 changes: 1 addition & 1 deletion src/components/Progress/index.stories.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React from 'react';
import * as React from 'react';

import Component from './component';
import '../../scss/index.js';
Expand Down
2 changes: 1 addition & 1 deletion src/components/RadioButton/index.stories.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React from 'react';
import * as React from 'react';

import Component from './component';
import '../../scss/index.js';
Expand Down
2 changes: 1 addition & 1 deletion src/components/SelectInput/index.stories.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React from 'react';
import * as React from 'react';

import Component from './component';
import '../../scss/index.js';
Expand Down
2 changes: 1 addition & 1 deletion src/components/SliderInput/index.stories.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React from 'react';
import * as React from 'react';

import Component from './component';
import '../../scss/index.js';
Expand Down
2 changes: 1 addition & 1 deletion src/components/Spinner/component.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React from 'react';
import * as React from 'react';
import Element, { SpinnerArgs } from './index';
import BaseComponent from '../Element/component';

Expand Down
2 changes: 1 addition & 1 deletion src/components/Spinner/index.stories.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React from 'react';
import * as React from 'react';

import SpinnerComponent from './component';
export default {
Expand Down
2 changes: 1 addition & 1 deletion src/components/TextAreaInput/index.stories.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React from 'react';
import * as React from 'react';

import Component from './component';
import '../../scss/index.js';
Expand Down
2 changes: 1 addition & 1 deletion src/components/TextInput/index.stories.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React from 'react';
import * as React from 'react';

import Component from './component';
import '../../scss/index.js';
Expand Down
2 changes: 1 addition & 1 deletion src/components/TreeView/component.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React from 'react';
import * as React from 'react';
import TreeViewElement, { TreeViewArgs } from './index';
import TreeViewItemElement from '../TreeViewItem/index';
import BaseComponent from '../Element/component';
Expand Down
2 changes: 1 addition & 1 deletion src/components/TreeView/index.stories.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React from 'react';
import * as React from 'react';

import TreeView from './component';
import TreeViewItem from '../TreeViewItem/component';
Expand Down
2 changes: 1 addition & 1 deletion src/components/VectorInput/index.stories.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React from 'react';
import * as React from 'react';

import Component from './component';
import '../../scss/index.js';
Expand Down
2 changes: 1 addition & 1 deletion src/examples/BidirectionalBinding/index.stories.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React from 'react';
import * as React from 'react';

import { Observer } from '@playcanvas/observer';
import Container from '../../components/Container/component';
Expand Down
2 changes: 1 addition & 1 deletion src/examples/Observer/index.stories.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React from 'react';
import * as React from 'react';

import { Observer } from '@playcanvas/observer';
import Container from '../../components/Container/component';
Expand Down
1 change: 0 additions & 1 deletion tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
"es2019",
"dom"
],
"allowSyntheticDefaultImports" : true,
"esModuleInterop" : true,
"sourceMap": true,
"moduleResolution": "node"
Expand Down