Update documentation #96
Conversation
hborawski
force-pushed
the
docs-update
branch
from
7a5ec61
to
4c0c37b
Compare
| @@ -45,7 +45,7 @@ The `id` of the views are used in the navigation section to reference a specific | |||
|
|
|||
| ## Cross-field validation | |||
|
|
|||
| The other special property of a `view` vs. an `asset` is the addition of a `validation` property on the view. These contains [`validation` objects](../guides/validation) that are used for validations crossing multiple fields, and are ran on user navigation rather than data change. | |||
| The other special property of a `view` vs. an `asset` is the addition of a `validation` property on the view. These contain [`validation` objects](../plugins/common-types#validations) that are used for validations crossing multiple fields, and are ran on user navigation rather than data change. | |||
There was a problem hiding this comment.
i think this should be referencing https://github.com/player-ui/player/blob/main/docs/site/pages/content/schema.mdx#validation rather than validations from a plugin
There was a problem hiding this comment.
It doesn't seem like I can do a relative link for this (../content/schema#validation). Is it fine if I use the full link: https://github.com/player-ui/player/blob/main/docs/site/pages/content/schema.mdx#validation?
There was a problem hiding this comment.
can you just do ./schema#validation since its also in the content folder?
There was a problem hiding this comment.
Oh yeah, sorry. My bad. That also doesn't work.
CONTRIBUTING.md
Outdated
| * [npm >= 8.19.2](https://docs.npmjs.com/downloading-and-installing-node-js-and-npm) | ||
| * [yarn >= 1.22.19](https://yarnpkg.com/) | ||
| * [Swift >= 5.2](https://www.swift.org/download/) | ||
| * [Android NDK = 19.2.5345600](https://github.com/android/ndk/wiki/Unsupported-Downloads#r19c). You'll need to add `ANDROID_NDK_HOME` to your environment manually. |
There was a problem hiding this comment.
We might need to explicitly call out the incompatibility with NDK version >21
There was a problem hiding this comment.
do we need bazel 6.x to bump up the android ndk?
There was a problem hiding this comment.
How's this?
- Android NDK >= 19.2.5345600, <= 21. Any version > 22 will not work, period. You'll need to add
ANDROID_NDK_HOMEto your environment manually.
There was a problem hiding this comment.
There was a problem hiding this comment.
https://github.com/ahumesky/rules_android_ndk
this specifically says version 25, so i'm assuming 22, 23, 24 don't work lol
| @@ -101,10 +101,6 @@ const PlatformTabs = (props: React.PropsWithChildren<unknown>) => { | |||
| CodeTabsNameMap.has(c.props.mdxType.toLowerCase()) | |||
| ); | |||
|
|
|||
| if (!router.isReady) { | |||
There was a problem hiding this comment.
Good catch! I am trying to remember the reason for including this but it looks like its not needed anymore.
router.isReadywhich shouldn't be used outside ofuseEffect(link). This causes a progress bar to appear until the user navigates to a different page and then navigates back (e.g. for the Asset Provide Plugin), so remove that.Version
Published prerelease version:
0.3.0-next.6Changelog
馃殌 Enhancement
ReactPlayer#93 (@adierkens)馃悰 Bug Fix
馃摑 Documentation
Authors: 8