Unity Multiplayer Server's heartbeat vanishes

[MScottAdams]

From https://github.com/PlayFab/UnitySDK/issues/226

Been chasing an issue where our game server loses its heartbeat. Our server actually switches scenes during its startup.

Root cause is missing code in PlayFabMultiplayerAgentView

Adding the following to the class fixed the issue:

public class PlayFabMultiplayerAgentView : MonoBehaviour
{
private float _timer;
/// <summary>
/// Awake constructor
/// </summary>
private void Awake()
{
    Debug.Log($"{Time.fixedTime} PlayFabMultiplayerAgentView awake ");

    // Need to keep this game object alive through scene changes.
    DontDestroyOnLoad(this);
}

/// <summary>
/// Called when gameobject is destroyed
/// </summary>
private void OnDestroy()
{
    Debug.Log($"{Time.fixedTime} PlayFabMultiplayerAgentView destroyed ");
}

[dgkanatsios]

thank you!

[MScottAdams]

Welcome! Sorry but I tried a couple of times but can't get the code indicators in the sample above working. It's probably easier to read it in original post on Unity SDK.

[dgkanatsios]

I think I fixed that, let me know if code looks like intended now.

[MScottAdams]

Thanks that is correct now!

[dgkanatsios]

Coming back to this, want to make a pull request on this repo adding the DontDestroyOnLoad method? We'd be more than happy to review, discuss and accept!

[MScottAdams]

Sorry as I mentioned before I just don't have the time currently to setup GIT and do all the required steps.

[CaptainPineapple]

I'd go a bit further and suggest a singleton approach since depending on the scenes setup a scenechange might result in multiple Object getting created. Thus i'd suggest to add these following changes instead:

public class PlayFabMultiplayerAgentView : MonoBehaviour
{
    /// <summary>
    /// Static reference to the current active instance of the PlayFabMultiplayerAgentView.
    /// </summary>
    public static PlayFabMultiplayerAgentView current;
    private float _timer;
    /// <summary>
    /// Awake constructor
    /// </summary>
    private void Awake()
    {
        Debug.Log($"{Time.fixedTime} PlayFabMultiplayerAgentView awake ");
        // Check if the static instance already contains a refernce:
        if (current)
        {
            // Destroy this instance since we only ever need one PlayFabMultiplayerAgentView
            Destroy(gameObject);
            return;
        }
        else
        {
            // Need to keep this game object alive through scene changes.
            DontDestroyOnLoad(this);
            current = this;
        }
    }

    /// <summary>
    /// Called when gameobject is destroyed
    /// </summary>
    private void OnDestroy()
    {
        Debug.Log($"{Time.fixedTime} PlayFabMultiplayerAgentView destroyed ");
    }
}

[dgkanatsios]

I believe we can close this due to #52, thanks @MScottAdams for bringing this up and @CaptainPineapple for the PR!