Call #asJava recursively in play.api.Configuration.from #938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now, for example, you need to write additionalConfiguration for FakeApplication like the following when it contains List[A]...
FakeApplication(
additionalConfiguration = Map("foo" -> List("a", "b", "c").asJava)
)
This is a API for Scala, so it isn't cool to call #asJava in this way.
I changed Configuration.from(data: Map[String, Any]) a little,
and It now convert the value of Map[String, Any] internaly to fit with the API of typesafeconfig.
jroper
added a commit
that referenced
this pull request
Apr 5, 2013
…figuration.from Call #asJava recursively in play.api.Configuration.from
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now, for example, you need to write additionalConfiguration for FakeApplication like the following when it contains List[A]...
This is a API for Scala, so it isn't cool to call #asJava in this way.
I changed Configuration.from(data: Map[String, Any]) a little,
and It now convert the value of Map[String, Any] internaly to fit with the API of typesafeconfig.