Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.10.x] make ImmutableLinkedHashMap serializable #945

Merged
merged 1 commit into from
Nov 4, 2023

Conversation

ramazanyich
Copy link
Contributor

@ramazanyich ramazanyich commented Oct 31, 2023

Pull Request Checklist

  • Have you read through the contributor guidelines?
  • Have you squashed your commits?
  • Have you added copyright headers to new files?
  • Have you updated the documentation?
  • Have you added tests for any changed functionality?

Fixes

Fixes #944

Purpose

In order to be able to serialize objects that contain JsObject as a member need to have internal underlying ImmutableLinkedHashMap implement serializable interface

@ramazanyich
Copy link
Contributor Author

have you an idea how I can test the serialization in scala-native.
Looks like problem is in fact that ObectInputStream/ObjectOutputStream is not included into javalibs of scala-native.
which gives a problem during test/NativeLink

@jtjeferreira
Copy link
Contributor

have you an idea how I can test the serialization in scala-native. Looks like problem is in fact that ObectInputStream/ObjectOutputStream is not included into javalibs of scala-native. which gives a problem during test/NativeLink

I think it is better to just have that test as JVM test in play-json/jvm/src/test/scala/play/api/libs/json

@ramazanyich
Copy link
Contributor Author

have you an idea how I can test the serialization in scala-native. Looks like problem is in fact that ObectInputStream/ObjectOutputStream is not included into javalibs of scala-native. which gives a problem during test/NativeLink

I think it is better to just have that test as JVM test in play-json/jvm/src/test/scala/play/api/libs/json

thanks for the tip

Copy link
Contributor

@jtjeferreira jtjeferreira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but would be better if a maintainer could have a look

@ramazanyich
Copy link
Contributor Author

@mkurz can you take a look on this PR

Copy link
Member

@mkurz mkurz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should work

@mkurz mkurz merged commit 10cd132 into playframework:2.10.x Nov 4, 2023
14 checks passed
@mkurz
Copy link
Member

mkurz commented Nov 4, 2023

@Mergifyio backport main

Copy link
Contributor

mergify bot commented Nov 4, 2023

backport main

✅ Backports have been created

mergify bot added a commit that referenced this pull request Nov 4, 2023
[main] make ImmutableLinkedHashMap serializable (backport #945) by @ramazanyich
@ihostage ihostage changed the title make ImmutableLinkedHashMap serializable [2.10.x] make ImmutableLinkedHashMap serializable Nov 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants