2.7.x fix context stop #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wsargent
commented
May 8, 2022
| @@ -80,7 +82,7 @@ public UserActor(@Assisted String id, | |||
| //.log("actorWebsocketFlow", logger) | |||
| .watchTermination((n, stage) -> { | |||
| // When the flow shuts down, make sure this actor also stops. | |||
| stage.thenAccept(f -> context().stop(self())); | |||
| Patterns.pipe(stage, getContext().dispatcher()).to(self()); | |||
wsargent
commented
May 8, 2022
| @@ -99,6 +101,8 @@ public Receive createReceive() { | |||
| .match(UnwatchStocks.class, unwatchStocks -> { | |||
| logger.info("Received message {}", unwatchStocks); | |||
| unwatchStocks(unwatchStocks.symbols); | |||
| }).match(Done.class, done -> { | |||
| context().stop(self()); | |||
There was a problem hiding this comment.
call context.stop inside receive block where it's safe
wsargent
commented
May 8, 2022
| @@ -62,6 +63,9 @@ class UserActor @Inject()(@Assisted id: String, @Named("stocksActor") stocksActo | |||
|
|
|||
| case UnwatchStocks(symbols) => | |||
| unwatchStocks(symbols) | |||
|
|
|||
| case Done => | |||
| context.stop(self) | |||
There was a problem hiding this comment.
Call context.stop from receive block
wsargent
commented
May 8, 2022
| @@ -75,7 +79,7 @@ class UserActor @Inject()(@Assisted id: String, @Named("stocksActor") stocksActo | |||
| // from the browse), using a coupled sink and source. | |||
| Flow.fromSinkAndSourceCoupled(jsonSink, hubSource).watchTermination() { (_, termination) => | |||
| // When the flow shuts down, make sure this actor also stops. | |||
| termination.foreach(_ => context.stop(self)) | |||
| termination.pipeTo(self) | |||
|
Thanks as well, I will activate GitHub actions for this repo tonight, so we can run tests for it. |
|
Closing / Re-opening to trigger that newly added GHA checks |
|
Ahh this PR is against the 2.7.x branch! I should have looked closer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for the context.stop bug described in https://discuss.lightbend.com/t/mergehub-is-not-cleaning-up-in-the-heap-area/9740