-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mock support #26
Comments
Maybe you have some advice regarding this issue on that repo? leanovate/play-mockws#20 If that work was done on that repo would you guys be able to make use of it as the 'official' play-ws mock or would you still probably implement your own one? |
Note that play-ws-standalone is a pure interface-only API, so whatever is under the hood in play-mockws should work fine. There's always going to be extra dependencies in any implementation. |
https://github.com/f100ded/play-fake-ws-standalone supports standalone play-ws |
@wsargent play-fake-ws-standalone works really well. Does it make sense to include it in play-ws distribution? |
@fehmicansaglam that is entirely up to @f100ded / @tartakynov |
@fehmicansaglam @wsargent I'd love to include it into play distribution, if Play's team agrees |
Okay! Brought it up for discussion at https://discuss.lightbend.com/t/adding-mock-to-play-ws-standalone/1227 -- the advantage is it would be visible in the documentation, downside is that it would have to be published on the same cycle as Play WS standalone itself (i.e. no step releases). |
It'd be nice to have mock WS client support, such as:
https://github.com/leanovate/play-mockws
The text was updated successfully, but these errors were encountered: