Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mock support #26

Open
wsargent opened this issue Dec 22, 2016 · 7 comments
Open

Add mock support #26

wsargent opened this issue Dec 22, 2016 · 7 comments

Comments

@wsargent
Copy link
Member

It'd be nice to have mock WS client support, such as:

https://github.com/leanovate/play-mockws

@MarkRBM
Copy link

MarkRBM commented Feb 7, 2017

Maybe you have some advice regarding this issue on that repo? leanovate/play-mockws#20

If that work was done on that repo would you guys be able to make use of it as the 'official' play-ws mock or would you still probably implement your own one?

@wsargent
Copy link
Member Author

wsargent commented Feb 7, 2017

Note that play-ws-standalone is a pure interface-only API, so whatever is under the hood in play-mockws should work fine. There's always going to be extra dependencies in any implementation.

@tartakynov
Copy link

https://github.com/f100ded/play-fake-ws-standalone supports standalone play-ws

@fehmicansaglam
Copy link

@wsargent play-fake-ws-standalone works really well. Does it make sense to include it in play-ws distribution?

@wsargent
Copy link
Member Author

wsargent commented Jun 6, 2018

@fehmicansaglam that is entirely up to @f100ded / @tartakynov

@tartakynov
Copy link

@fehmicansaglam @wsargent I'd love to include it into play distribution, if Play's team agrees

@wsargent
Copy link
Member Author

wsargent commented Jun 7, 2018

Okay! Brought it up for discussion at https://discuss.lightbend.com/t/adding-mock-to-play-ws-standalone/1227 -- the advantage is it would be visible in the documentation, downside is that it would have to be published on the same cycle as Play WS standalone itself (i.e. no step releases).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants