New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use jdk.CollectionConverters instead of deprecated JavaConverters #684

Merged

octonato merged 1 commit into playframework:main from xuwei-k:remove-JavaConverters

Jun 16, 2022

Contributor

xuwei-k commented Jun 16, 2022 •

edited

Pull Request Checklist

Have you read through the contributor guidelines?
Have you signed the Typesafe CLA?
Have you squashed your commits?
Have you added copyright headers to new files?
Have you checked that both Scala and Java APIs are updated?
Have you updated the documentation for both Scala and Java sections?
Have you added tests for any changed functionality?

Fixes

Purpose

fix warnings.

Background Context

Upgrade to latest akka 2.6.16 #603 play-ws drop Scala 2.12 support.
JavaConverters deprecated since Scala 2.13 https://github.com/scala/scala/blob/v2.13.8/src/library/scala/collection/JavaConverters.scala#L78

References


          use jdk.CollectionConverters instead of deprecated JavaConverters

8fefd31

octonato approved these changes

View reviewed changes

Contributor

octonato left a comment

LGTM

octonato merged commit d42d6dd into playframework:main

xuwei-k deleted the remove-JavaConverters branch

June 16, 2022 07:43

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment