Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to latest akka 2.6.16 #603

Merged
merged 3 commits into from
Sep 1, 2021
Merged

Conversation

mkurz
Copy link
Member

@mkurz mkurz commented Aug 19, 2021

Also fixes #601

@mkurz mkurz requested a review from SethTisue August 19, 2021 14:19
@mkurz
Copy link
Member Author

mkurz commented Aug 19, 2021

Actually there is a problem with the travis config, see https://app.travis-ci.com/github/playframework/play-ws/jobs/532586654#L229

$ export TRAVIS_SCALA_VERSION=2.12.14
...
$ sbt ++$TRAVIS_SCALA_VERSION 'testOnly -- xonly timefactor 5'
Detected sbt version 1.5.5
Using jvm options defined in file /etc/sbt/jvmopts
# Executing command line:
java
-Xms2048M
-Xmx2048M
-Xss6M
-XX:MaxPermSize=512M
-jar
/home/travis/.sbt/launchers/1.5.5/sbt-launch.jar
++2.13.6                                                                <<<------------- WHY?????
"testOnly -- xonly timefactor 5"

It runs with scala 2.13.6 instead of 2.12.14

the Scala version handling was not working as intended
@SethTisue
Copy link
Member

@mkurz I redid the Travis-CI config. but on 2.12 there's still a 0.8 vs 1.0 problem with scala-java8-compat

@mkurz
Copy link
Member Author

mkurz commented Aug 19, 2021

Green after dropping Scala 2.12 🚀

@mkurz mkurz merged commit e7dff2a into playframework:main Sep 1, 2021
@mkurz mkurz deleted the akka_2.6.16 branch September 1, 2021 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove line
2 participants