[#109] more robust Validation.error() and Validation.errors()

framework/src/play/data/validation/Validation.java

@@ -83,7 +83,7 @@ public static boolean hasErrors() {
      */
     public static Error error(String field) {
         for (Error error : current.get().errors) {
-            if (error.key.equals(field)) {
+            if (error.key!=null && error.key.equals(field)) {
                 return error;
             }
         }
@@ -97,7 +97,7 @@ public static Error error(String field) {
     public static List<Error> errors(String field) {
         List<Error> errors = new ArrayList<Error>();
         for (Error error : current.get().errors) {
-            if (error.key.equals(field)) {
+            if (error.key!=null && error.key.equals(field)) {
                 errors.add(error);
             }
         }

framework/test-src/play/data/validation/ValidationTest.java

@@ -0,0 +1,37 @@
+package play.data.validation;
+
+import org.junit.Test;
+import play.i18n.MessagesBuilder;
+
+import static org.fest.assertions.Assertions.assertThat;
+
+public class ValidationTest {
+
+    @Test
+    public void verifyError() {
+
+        new MessagesBuilder().build();
+
+        Validation.current.set(new Validation());
+
+        final String field = "f1";
+
+        assertThat(Validation.error(field)).isNull();
+        assertThat(Validation.errors(field)).isEmpty();
+
+        final String errorMsg = "My errorMessage";
+
+        Validation.addError(field, errorMsg);
+
+        assertThat( Validation.error(field).message).isEqualTo(errorMsg);
+        assertThat(Validation.errors(field)).containsOnly(Validation.error(field));
+
+        // ticket [#109] - add an error with null-key
+        Validation.addError(null, errorMsg);
+        // make sure this null key does not break stuff
+        assertThat( Validation.error(field).message).isEqualTo(errorMsg);
+        assertThat(Validation.errors(field)).containsOnly(Validation.error(field));
+
+    }
+
+}

framework/test-src/play/i18n/MessagesBuilder.java

@@ -0,0 +1,16 @@
+package play.i18n;
+
+import java.util.Properties;
+
+/**
+ * Used to prepare Messages (static) to work while testing
+ */
+public class MessagesBuilder {
+
+
+    public Properties defaults = new Properties();
+
+    public void build() {
+        Messages.defaults = defaults;
+    }
+}