#1437: play auto-test can return an exit code of zero when the te… #1435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o when the tests do not run
asolntsev
approved these changes
Dec 29, 2022
aleksandy
reviewed
Jan 8, 2023
| @@ -148,12 +148,20 @@ def autotest(app, args): | |||
| opener.open('%s://localhost:%s/@kill' % (protocol, http_port)) | |||
| except Exception as e: | |||
| pass | |||
|
|
|||
|
|
|||
| testCompleted = False | |||
There was a problem hiding this comment.
In my opinion introducing the new variable is not necessary. The testspassed (line 157) should be used instead.
There was a problem hiding this comment.
Agreed, it can be solved with one variable. Agreed, it is a matter of opinion whether it should be included. My reasoning for providing it was to speak to three potential states of interest: 1) tests failed to run; 2) tests ran but failed; and 3) tests ran and passed. A single boolean loses this level of resolution. Whatever you decide to do here is fine with me.
xael-fry
approved these changes
Jul 15, 2023
xael-fry
changed the title
|
Merged in master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…sts do not run
Pull Request Checklist
Helpful things
Fixes
git hub issue #1437
play auto-test can return an exit code of zero when the tests do not run due to the application failing to start. This can occur as a result of an unhandled exception when initializing a module or a compiler error within the application.
Purpose
Exists with return value of -1 when tests have not run.
Background Context
Jenkins was not reporting errors with play projects, was reporting everything working, even though tests were failing to run.
References
#1437