Fix for #479 #237
Closed
Fix for #479 #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For performance
…nd JPAModelLoader
…osite keys (at least in hsql)
Also refactor fields traversal and ignore non-mapped classes in the hierarchy. Also refactor binder for slightly saner code.
The binding is necessary because it was removed from the factory as this caused a mismatch with JPABase.findById that did not make sense.
…nse. It is possible that the first error message was explicitely desired, however I am not sure it made more sense.
Turns out that with refactoring a validation error that wasn't previously reported is not reported: In JPAPlugin.bind we try to find an entity from the DB if it has an ID, and previously we didn't add any validation error if that entity was not found. On the other hand, code that did the same thing but for relations like collections or @*ToOne relations, DID produce an error on invalid IDs in GenericModel. So toplevel invalid ID was no error, but nested invalid ID was error. With the refactoring now both toplevel and nested entity binding from the DB use the same code, which adds the error, making it more consistent. Therefore, I have dropped the invalid ID from the binding tests to make sure we did not get any error about that since we wanted to validate the Color enum binding. And I added a new test to make sure that invalid IDs do get us an error.
|
This has been somehow merged and enhanced in play 1.2.4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://play.lighthouseapp.com/projects/57987-play-framework/tickets/479
Replaces #55
I've split it up nice and simple so you can see why you also want the refactorings for simplifying the binder and the Factory caching for performance reasons.
Also this is now against the 1.2.1 tag