Fix for #479 #55
Closed
Fix for #479 #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…osite keys (at least in hsql)
Also refactor fields traversal and ignore non-mapped classes in the hierarchy. Also refactor binder for slightly saner code.
The binding is necessary because it was removed from the factory as this caused a mismatch with JPABase.findById that did not make sense.
…nse. It is possible that the first error message was explicitely desired, however I am not sure it made more sense.
|
Could you limit the patch to the functionality itself? You've moved code around (for example you moved JPAModelLoaders to its own file) and as a result the patch is huge and very hard to review. |
|
I've made a new pull request at #237 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.