[#188] Fix eclipsify - problem when mismatch between project name and folder name #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f project name in launch config files
fehmicansaglam
pushed a commit
to fehmicansaglam/play
that referenced
this pull request
Apr 21, 2012
…ied in application.conf
|
Reading the ticket, I should not apply this pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[#188] Fix eclipsify - use project folder name instead of project name in launch config files
Hi,
I fix the problem when use eclipsify on a project with a project name different from the project base folder name.
Eclipsify now use project folder name in generated launch config files instead of the project name. I also change the variable name from %PROJECT_NAME% to %PROJECT_BASENAME% in template files in order to keep consistency.
I hope it helps.
Sylvain