Rm trailing whitespace in all plaintext files #350
Conversation
|
LGTM. Ship it! |
|
Don’t do this for .textile files, where trailing whitespace is significant, signifying a continuation of a code block. Your version will have code examples where code formatting stops at the first blank line. |
Trailing whitespace can be significant in textile files, signifying the continuation of a code block.
|
Cannot merge this request.. too many changes. You have also modified lots of "bundled" core-python files. |
|
What can I do to split it up? The amount of trailing whitespace is pretty egregious. |
|
you have transformed many files which are original file from other frameworks just bundled with playframework, eg: all files under the folder 'python/' is core-python filed.. I also see that you have modified original selenium files.. also: please read the https://play.lighthouseapp.com/projects/57987/contributor-guide |
|
Seems odd that core Python and Selenium files are included here... but I will read the guide and possibly come up with a more sensible changeset. This pull req wasn't meant as a troll. :P Thanks for the feedback. |
|
no problem at all. Play's philosophy is to make it easy to use. Since python is not "default" on Windows, we have to bundle it.. Other stuff is also bundled for the "easy to use" reason. Play 2.0 is not going to use any python at all.. No offense taken :) |
Trailing whitespace makes babies cry and the Play framework is littered with it.
Removes trailing whitespace from all plaintext files within the framework. Made an effort to not include any binaries, but please advise if I've cleansed something I shouldn't have.