[#1731] Improve error handling in onApplicationStop() method #664
Conversation
If some plugin throws exception in onApplicationStop() method, onApplicationStop() is not called for other plugins. Instead, we should log it and continue to call other plugins.
|
play-1-3-x-pull-requests #53 FAILURE |
|
Jenkins failure does not seem to be related to my change. |
|
indeed, must have been a hickup. could you a lighthouse request for this issue|? |
Otherwise the error message (at INFO level) is rather useless.
|
play-1-3-x-pull-requests #63 FAILURE |
|
Again, Jenkins failure does not seem to be related to my change. (the same problem is still there, as before?) |
|
yep.. weird. I can't imagime how your change could cause it.. could you add a lighthouse issue? |
|
ah, just realized @pepite did some work to make 1.3.x work on cloudbees - these chnages are not in 1.2.x, so that explains it. |
|
I did add a lighthouse issue. In case you missed it, here it is: http://play.lighthouseapp.com/projects/57987/tickets/1731-improve-error-handling-in-onapplicationstop-method |
|
ah. I missed it. thanks. |
| if (t.getMessage() == null) | ||
| Logger.error(t, "Error while stopping %s", plugin); | ||
| else if (Logger.isDebugEnabled()) | ||
| Logger.debug(t, "Error while stopping %s", plugin); |
There was a problem hiding this comment.
I don't understand why you put different level of Log for the same exception, I think you can use error level
There was a problem hiding this comment.
When shutting down, there can be all kinds of exceptions flying around and most of them are not interesting - so I log the stack trace only if the exception message is missing (e.g. NPE) or if DEBUG level is enabled. In short: this reduces the verbosity of the logs.
There was a problem hiding this comment.
though not very intuitive, it seems reasonable. I'll merge it.
|
merged. thanks. |
If some plugin throws exception in onApplicationStop() method, onApplicationStop() is not called for other plugins.
Instead, we should log it and continue to call other plugins.