[#1823] Fix play.exceptions.CompilationException

[xael-fry]

lighthouse #1823

[cloudbees-pull-request-builder]

play-1-3-x-pull-requests #243 FAILURE
Looks like there's a problem with this pull request

[xael-fry]

@Notalifeform could you have a look on my PR (some tests to check if there isn't any problem on mac, forx ex)?

[cloudbees-pull-request-builder]

play-1-3-x-pull-requests #244 FAILURE
Looks like there's a problem with this pull request

[flybyray]

I don´t know who that came into it. My original PR was
if (javaFile.exists() && javaFile.isDirectory()) {
return null; // we found a package
}

[xael-fry]

Yes but as I said there was still problem with your PR, your PR only work with play precompile.
example with name = controllers.Application, it was sometimes detect as a directory on windows.

[flybyray]

I think the problem is than, that the name of a directory must be cheched as well by its canonical name. My implementation was base on the assumption, that java packages must be allways lower case and i do not have to check the directory for case insensitivity. I will update my pull request.
You tested this with the normal "play run" on the small sample application from #786 1823 lighthouse ticket?
synapplix@e76ded2

[xael-fry]

Yes I used the project sample attached to the issue, I run also the ApplicationTest as a Junit Test. The function matchName just do waht you said : directory "must be cheched as well by its canonical name".
So I think my change are ok, aren't they?

[flybyray]

no it is not I think on this line it must be:
javaFile.matchName(fileOrDir)
and not
javaFile.matchName(fileName)

[flybyray]

Nevertheless with this patch we have a new problem with the template code itself.
You can run the simple testapp ( like in http://play.lighthouseapp.com/projects/57987/tickets/1823-windows-support-eclipse-jdt-compiler ). But if you call the controller action for the subpackage Application http://localhost:9000/application.Application/index you will get a template not found message.
On Windows you will need to create a "Application" directory within the existing "Application" directory:
\testapp\app\views\Application\index.html
\testapp\app\views\Application\Application\index.html

On Linux it is possible to create two different directories "application" and "Application":
\testapp\app\views\Application\index.html
\testapp\app\views\application\Application\index.html

Perhaps a other naming schema for templates would be better something like this:
\testapp\app\views\Application.index.html
\testapp\app\views\application\Application.index.html

[xael-fry]

We cannot change the naming schema for templates, I thinks the simpliest solution to make it work on windows is not to user the render function but use renderTemplate instead

[cloudbees-pull-request-builder]

play-1-3-x-pull-requests #246 FAILURE
Looks like there's a problem with this pull request

[flybyray]

How is it possible to see the actual failure of this build? If I click on the link i only see a Login screen from CloudBees. Is there any chance to get the build script to try the same on our own jenkins server (i hate those restrictive build services, hope you will leave it soon)?

[xael-fry]

Yes I saw that since some update from cloudee, anonymous cannot access build, I try to male make it accessible.
The problem is :

[exec] 02:53:14,223 TRACE ~ Plugin play.plugins.ConfigurablePluginD~ The application does not start. There are errors: java.io.IOException: Server returned HTTP response code: 500 for URL: http://localhost:9003/@tests.list

We have it for all PR base on the 1.3.x branch, but I don't know why, as I didn't have this issue on my computer.

[Notalifeform]

@flybyray anonymous access to cloudbees has been restored
@xael-fry all test for this branch pass now on OSX