Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#1846] Add monitoring (events) to template rendering... #792

Open
wants to merge 18 commits into
base: 1.3.x
Choose a base branch
from
Open

[#1846] Add monitoring (events) to template rendering... #792

wants to merge 18 commits into from

Conversation

PerfectCarl
Copy link
Contributor

#779... JPQL queries and JPA operations.

See this ticket

Basically, it will help profiling modules to display database and rendering time

Like this

@PerfectCarl
Add monitoring (events) to template rendering, JPQL queries and JPA o…
2a7e74a 
…peration
@PerfectCarl
Merge branch '1.3.x' of https://github.com/playframework/play1 into p…
1715bb6 
…lay13_monitoring

Conflicts:
	framework/src/play/mvc/Controller.java
@PerfectCarl
Create monitoring.textile
1177629
@PerfectCarl
Update and rename monitoring.textile to events.textile
97124ee
@PerfectCarl
Update events.textile
6ab3b6a
@PerfectCarl
Update events.textile
9e035e9
@PerfectCarl
Update events.textile
d8fa2e8
@PerfectCarl
Update events.textile
33322b2
@PerfectCarl
Update events.textile
b2b9baa
@PerfectCarl
Update events.textile
f5f86f9
@PerfectCarl
Update events.textile
8bd50e3
@PerfectCarl
Update events.textile
c88574b
@PerfectCarl
Update events.textile
37b9aee
@PerfectCarl
Fix the botched merge
cc3ab9a
@PerfectCarl
Update events.textile
7e49e91
@PerfectCarl
Merge branch '1.3.x' of https://github.com/playframework/play1 into p…
3650696 
…lay13_monitoring
@PerfectCarl
Merge branch 'play13_monitoring' of https://github.com/PerfectCarl/play1
dfa161e 
 into play13_monitoring
@PerfectCarl
Update events.textile
5dfde1e
@PerfectCarl
Copy link
Contributor Author

Fixed merge. With documentation (events.textile)

@cloudbees-pull-request-builder
Copy link

play-1-3-x-pull-requests #258 FAILURE
Looks like there's a problem with this pull request

@PerfectCarl
Copy link
Contributor Author

any news on this ?

@pepite
Copy link
Contributor

pepite commented Oct 27, 2014

Quite frankly, this should be done within a module and not within the core. I think you should be able to do that with the current API and by extending the JPA module.

@pepite pepite closed this Oct 27, 2014
@PerfectCarl
Copy link
Contributor Author

@pepite Well, as a matter of fact, using the existing JPA module didn't yield interesting results and the code was starting to be a fragile mess.
Leveraging that existing framework feature seemed more elegant.

Trust me, I really wished to do that using the module feature. Maybe there is a way that I didn't consider. Have you any pointer?

By the way, asking to document the patch and not accepting it is rude. Next time could you make your mind beforehand?

@xael-fry xael-fry reopened this May 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@PerfectCarl @cloudbees-pull-request-builder @pepite @xael-fry