Skip to content

Commit

Permalink
Remove use of notTransitive
Browse files Browse the repository at this point in the history
SBT's notTransitive declaration is ignored when generating a pom.xml
(see sbt/sbt#2276), which, since we publish
maven style, means it has no effect outside of the Play project itself.

Instead, it must be replaced with individual exclusions.  In particular,
the findbugs annotations dependency from reflections must be excluded,
because it's LGPL, which prevents Play users from distributing a Play
application under their own license.
  • Loading branch information
jroper committed Nov 17, 2015
1 parent 5c6a8a6 commit c876d21
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions framework/project/Dependencies.scala
Expand Up @@ -67,22 +67,22 @@ object Dependencies {
// This is depended on by hibernate validator, we upgrade to 3.2.0 to avoid LGPL license of 3.1.x
"org.jboss.logging" % "jboss-logging" % "3.2.1.Final",

("org.springframework" % "spring-context" % springFrameworkVersion notTransitive ())
("org.springframework" % "spring-context" % springFrameworkVersion)
.exclude("org.springframework", "spring-aop")
.exclude("org.springframework", "spring-beans")
.exclude("org.springframework", "spring-core")
.exclude("org.springframework", "spring-expression")
.exclude("org.springframework", "spring-asm"),

("org.springframework" % "spring-core" % springFrameworkVersion notTransitive ())
("org.springframework" % "spring-core" % springFrameworkVersion)
.exclude("org.springframework", "spring-asm")
.exclude("commons-logging", "commons-logging"),

("org.springframework" % "spring-beans" % springFrameworkVersion notTransitive ())
("org.springframework" % "spring-beans" % springFrameworkVersion)
.exclude("org.springframework", "spring-core"),

("org.reflections" % "reflections" % "0.9.9" notTransitive ())
.exclude("javassist", "javassist"),
("org.reflections" % "reflections" % "0.9.9")
.exclude("com.google.code.findbugs", "annotations"),

// Used by the Java routing DSL
"net.jodah" % "typetools" % "0.4.3",
Expand Down

0 comments on commit c876d21

Please sign in to comment.