Play 2.2.x doc related to CSRF is incorrect

[armsargis]

Hi, I am just learning Play and using Scala so I follow docs:http://www.playframework.com/documentation/2.2.x/ScalaCsrf and find out that it does not work, if I add:

object Global extends WithFilters(CSRFFilter()) with GlobalSettings

as described I got

play.api.PlayException: Cannot init the Global object[null]
at play.api.WithDefaultGlobal$$anonfun$play$api$WithDefaultGlobal$$globalInstance$1.apply(Application.scala:55) ~[play_2.10.jar:2.2.0]
at play.api.WithDefaultGlobal$$anonfun$play$api$WithDefaultGlobal$$globalInstance$1.apply(Application.scala:49) ~[play_2.10.jar:2.2.0]
at play.utils.Threads$.withContextClassLoader(Threads.scala:18) ~[play_2.10.jar:2.2.0]
at play.api.WithDefaultGlobal$class.play$api$WithDefaultGlobal$$globalInstance(Application.scala:48) ~[play_2.10.jar:2.2.0]
at play.api.DefaultApplication.play$api$WithDefaultGlobal$$globalInstance$lzycompute(Application.scala:399) ~[play_2.10.jar:2.2.0]
at play.api.DefaultApplication.play$api$WithDefaultGlobal$$globalInstance(Application.scala:399) ~[play_2.10.jar:2.2.0]
Caused by: java.lang.ExceptionInInitializerError: null
at sun.misc.Unsafe.ensureClassInitialized(Native Method) ~[na:1.7.0_40]
at sun.reflect.UnsafeFieldAccessorFactory.newFieldAccessor(UnsafeFieldAccessorFactory.java:43) ~[na:1.7.0_40]
at sun.reflect.ReflectionFactory.newFieldAccessor(ReflectionFactory.java:140) ~[na:1.7.0_40]
at java.lang.reflect.Field.acquireFieldAccessor(Field.java:1057) ~[na:1.7.0_40]
at java.lang.reflect.Field.getFieldAccessor(Field.java:1038) ~[na:1.7.0_40]
at java.lang.reflect.Field.get(Field.java:379) ~[na:1.7.0_40]
Caused by: java.lang.RuntimeException: There is no started application
at scala.sys.package$.error(package.scala:27) ~[scala-library.jar:na]
at play.api.Play$$anonfun$current$1.apply(Play.scala:68) ~[play_2.10.jar:2.2.0]
at play.api.Play$$anonfun$current$1.apply(Play.scala:68) ~[play_2.10.jar:2.2.0]
at scala.Option.getOrElse(Option.scala:120) ~[scala-library.jar:na]
at play.api.Play$.current(Play.scala:68) ~[play_2.10.jar:2.2.0]
at play.filters.csrf.CSRFConf$.c(csrf.scala:10) ~[filters-helpers_2.10.jar:2.2.0]
[warn] play - No application found at invoker init

To fix it I did

1. In Global:
   override def doFilter(action:EssentialAction) = CSRFFilter().apply(next = action)

2. in *.scala.html have to add: (implicit token: play.filters.csrf.CSRF.Token) as part of parameters

[jroper]

This kinda sucks, to make it work nicely, we'll have to make all the constructor arguments to CSRFFilter by name parameters, which will break binary compatibility. Perhaps we could make a constructor with non by name parameters to maintain backwards compatibility... maybe that will work, maybe not. Unfortunately, even though the documentation was extracted out into separate code files, because the Global object in the documentation was instantiated in the context of a running app, it didn't pick up this issue.

[armsargis]

I did not catch --> ' Global object in the documentation was instantiated in the context of a running app' can you provide code what is the correct way to define Global object. Thanks.

[jroper]

The workaround you posted is correct, my comment was a note for the next person in the Play team who looks at this. The way we've published it in the docs is the way we want it to be used, so we'll want to fix the CSRFFilter so it does work that way, but unfortunately it's not going to be a straight forward fix.

[armsargis]

Okay, thanks for response.