Add Java APIs for TestServer.runningHttpPort and TestServer.runningHttpsPort

[marcospereira]

Play Version

2.6.4 and above.

API

Java.

Expected Behavior

We need to have Java APIs for TestServer.runningHttpPort and TestServer.runningHttpsPort. Ideally, these APIs will return an Optional<Integer>.

Actual Behavior

We currently have TestServer.port which is deprecated:

playframework/framework/src/play-test/src/main/scala/play/api/test/TestServer.scala

Lines 72 to 76 in 21ba2d6

	/**
	* The port that the server is running on.
	*/
	@deprecated("Using runningHttpPort or runningHttpsPort instead", "2.6.4")
	def port: Int = config.port.getOrElse(throw new IllegalStateException("No HTTP port defined"))

And it is recommending to use either TestServer.runningHttpPort:

playframework/framework/src/play-test/src/main/scala/play/api/test/TestServer.scala

Lines 78 to 81 in 21ba2d6

	/**
	* The HTTP port that the server is running on.
	*/
	def runningHttpPort: Option[Int] = getTestServerIfRunning.httpPort

Or TestServer.runningHttpsPort:

playframework/framework/src/play-test/src/main/scala/play/api/test/TestServer.scala

Lines 83 to 86 in 21ba2d6

	/**
	* The HTTPS port that the server is running on.
	*/
	def runningHttpsPort: Option[Int] = getTestServerIfRunning.httpsPort

But both are returning Option[Int]. That is a Scala API, and we need to add the Java correspondents.

[Shenker93]

Java 8 also provides OptionalInt container class, it wraps primitive int value instead of Integer, so container object is little bit more lightweight and more precisely conveys the essence. It also lets to avoid unnecessary boxing-unboxing operations in client code. I think it is better to use such approach here. @marcospereira , what do you think of it? I can open a PR and override such methods for java API

[marcospereira]

@Shenker93 makes sense to me.

I can to open a PR and override such methods for java API

Thank you!