Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add withThreshold and withCompressionLevel to GzipFilterConfig #10042

Merged
merged 2 commits into from Feb 7, 2020
Merged

Add withThreshold and withCompressionLevel to GzipFilterConfig #10042

merged 2 commits into from Feb 7, 2020

Conversation

slisaasquatch
Copy link
Contributor

Pull Request Checklist

Helpful things

Fixes

Fixes #10040

Purpose

Adds withThreshold to GzipFilterConfig to make it accessible in Java.

Background Context

N/A

References

N/A

mkurz
mkurz approved these changes Feb 6, 2020
View reviewed changes
Copy link
Member

@mkurz mkurz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Will land in Play 2.8.2.

@mkurz mkurz added this to the Play 2.8.2 milestone Feb 6, 2020
@mergify mergify bot merged commit 86418b4 into playframework:2.8.x Feb 7, 2020
@slisaasquatch slisaasquatch deleted the issue-10041-2 branch February 7, 2020 17:46
@mkurz mkurz mentioned this pull request Apr 1, 2020
Closed
@mkurz mkurz mentioned this pull request May 15, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkurz mkurz mkurz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Play 2.8.2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@slisaasquatch @mkurz